[gazelle] Use javaLibraryRuleKind instead of hard-coding the type (#369)

shs96c · web-flow · commit a72a720e239f · 2025-10-06T12:57:40.000+01:00
diff --git a/java/gazelle/generate.go b/java/gazelle/generate.go
@@ -472,8 +472,7 @@ func accumulateJavaFile(cfg *javaconfig.Config, testJavaFiles, testHelperJavaFil
 }
 
 func (l javaLang) generateJavaLibrary(file *rule.File, pathToPackageRelativeToBazelWorkspace, name string, srcsRelativeToBazelWorkspace []string, packages, imports, exports *sorted_set.SortedSet[types.PackageName], annotationProcessorClasses *sorted_set.SortedSet[types.ClassName], testonly bool, javaLibraryRuleKind string, res *language.GenerateResult, cfg *javaconfig.Config, repoName string) {
-	const ruleKind = "java_library"
-	r := rule.NewRule(ruleKind, name)
+	r := rule.NewRule(javaLibraryRuleKind, name)
 
 	srcs := make([]string, 0, len(srcsRelativeToBazelWorkspace))
 	for _, src := range srcsRelativeToBazelWorkspace {

Original file line number	Diff line number	Diff line change
`@@ -472,8 +472,7 @@ func accumulateJavaFile(cfg *javaconfig.Config, testJavaFiles, testHelperJavaFil`
`472`	`472`	`}`
`473`	`473`
`474`	`474`	`func (l javaLang) generateJavaLibrary(file rule.File, pathToPackageRelativeToBazelWorkspace, name string, srcsRelativeToBazelWorkspace []string, packages, imports, exports sorted_set.SortedSet[types.PackageName], annotationProcessorClasses sorted_set.SortedSet[types.ClassName], testonly bool, javaLibraryRuleKind string, res language.GenerateResult, cfg *javaconfig.Config, repoName string) {`
`475`		`- const ruleKind = "java_library"`
`476`		`- r := rule.NewRule(ruleKind, name)`
	`475`	`+ r := rule.NewRule(javaLibraryRuleKind, name)`
`477`	`476`
`478`	`477`	`srcs := make([]string, 0, len(srcsRelativeToBazelWorkspace))`
`479`	`478`	`for _, src := range srcsRelativeToBazelWorkspace {`