Fix pmd_test to use short_path instead of path for sources (#390)

styurin · web-flow · commit fa1c1849c762 · 2025-11-19T03:21:40.000Z
From https://bazel.build/rules/lib/builtins/File#path: > Use the `short_path` for the path under which the file is mapped if it's in the runfiles of a binary. Fixes an issue with `pmd_test` not finding sources produced by other targets.
diff --git a/java/private/pmd.bzl b/java/private/pmd.bzl
@@ -21,7 +21,7 @@ def _pmd_test_impl(ctx):
     file_list = ctx.actions.declare_file("%s-pmd-srcs" % ctx.label.name)
     ctx.actions.write(
         file_list,
-        ",".join([src.path for src in ctx.files.srcs]),
+        ",".join([src.short_path for src in ctx.files.srcs]),
     )
     cmd.extend(["--file-list", file_list.short_path])
     inputs.extend(ctx.files.srcs)

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ def _pmd_test_impl(ctx):`
`21`	`21`	`file_list = ctx.actions.declare_file("%s-pmd-srcs" % ctx.label.name)`
`22`	`22`	`ctx.actions.write(`
`23`	`23`	`file_list,`
`24`		`- ",".join([src.path for src in ctx.files.srcs]),`
	`24`	`+ ",".join([src.short_path for src in ctx.files.srcs]),`
`25`	`25`	`)`
`26`	`26`	`cmd.extend(["--file-list", file_list.short_path])`
`27`	`27`	`inputs.extend(ctx.files.srcs)`