Add c++17 constraint to other toolchains which get registered in different tests, add host_platform repo in non bzlmod tests

Author: jkurland-roku

tests/MODULE.bazel

@@ -111,6 +111,11 @@ llvm.toolchain(
         "darwin-aarch64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.7/clang+llvm-15.0.7-arm64-apple-darwin22.0.tar.xz"],
         "darwin-x86_64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.7/clang+llvm-15.0.7-x86_64-apple-darwin21.0.tar.xz"],
     },
+    cxx_standard = {"": "c++17"},
+)
+llvm.extra_target_compatible_with(
+    name = "llvm_toolchain_with_urls",
+    constraints = ["@//:cxx17"],
 )
 use_repo(llvm, "llvm_toolchain_with_urls")
 
@@ -121,6 +126,11 @@ use_repo(llvm, "llvm_toolchain_with_urls")
 llvm.toolchain(
     name = "llvm_toolchain_13_0_0",
     llvm_version = "13.0.0",
+    cxx_standard = {"": "c++17"},
+)
+llvm.extra_target_compatible_with(
+    name = "llvm_toolchain_13_0_0",
+    constraints = ["@//:cxx17"],
 )
 use_repo(llvm, "llvm_toolchain_13_0_0")
 
@@ -129,6 +139,11 @@ llvm.toolchain(
     name = "llvm_toolchain_with_absolute_paths",
     absolute_paths = True,
     llvm_versions = LLVM_VERSIONS,
+    cxx_standard = {"": "c++17"},
+)
+llvm.extra_target_compatible_with(
+    name = "llvm_toolchain_with_absolute_paths",
+    constraints = ["@//:cxx17"],
 )
 # We can share the downloaded LLVM distribution with the first configuration.
 llvm.toolchain_root(
@@ -141,6 +156,11 @@ use_repo(llvm, "llvm_toolchain_with_absolute_paths")
 llvm.toolchain(
     name = "llvm_toolchain_with_system_llvm",
     llvm_versions = LLVM_VERSIONS,
+    cxx_standard = {"": "c++17"},
+)
+llvm.extra_target_compatible_with(
+    name = "llvm_toolchain_with_system_llvm",
+    constraints = ["@//:cxx17"],
 )
 # For this toolchain to work, the LLVM distribution archive would need to be unpacked here.
 llvm.toolchain_root(
@@ -153,6 +173,11 @@ use_repo(llvm, "llvm_toolchain_with_system_llvm")
 llvm.toolchain(
     name = "llvm_toolchain_with_sysroot",
     llvm_versions = LLVM_VERSIONS,
+    cxx_standard = {"": "c++17"},
+)
+llvm.extra_target_compatible_with(
+    name = "llvm_toolchain_with_sysroot",
+    constraints = ["@//:cxx17"],
 )
 # We can share the downloaded LLVM distribution with the first configuration.
 llvm.toolchain_root(
@@ -177,5 +202,10 @@ llvm.toolchain(
     # distribution = "clang+llvm-17.0.6-x86_64-linux-gnu-ubuntu-22.04.tar.xz",
     exec_os = "linux",
     exec_arch = "amd64",
+    cxx_standard = {"": "c++17"},
+)
+llvm.extra_target_compatible_with(
+    name = "llvm_toolchain_linux_exec",
+    constraints = ["@//:cxx17"],
 )
 use_repo(llvm, "llvm_toolchain_linux_exec")

tests/WORKSPACE

@@ -57,6 +57,10 @@ llvm_toolchain(
 # TODO(siddharthab): Add test.
 llvm_toolchain(
     name = "llvm_toolchain_with_urls",
+    cxx_standard = {"": "c++17"},
+    extra_target_compatible_with = {
+        "": ["@//:cxx17"],
+    },
     llvm_versions = LLVM_VERSIONS,
     sha256 = {
         "": "38bc7f5563642e73e69ac5626724e206d6d539fbef653541b34cae0ba9c3f036",
@@ -81,6 +85,10 @@ llvm_toolchain(
 # image base-devel as of the time of this writing (23 May 2022).
 llvm_toolchain(
     name = "llvm_toolchain_13_0_0",
+    cxx_standard = {"": "c++17"},
+    extra_target_compatible_with = {
+        "": ["@//:cxx17"],
+    },
     llvm_version = "13.0.0",
 )
 
@@ -96,6 +104,10 @@ llvm_register_toolchains_cxx20()
 llvm_toolchain(
     name = "llvm_toolchain_with_absolute_paths",
     absolute_paths = True,
+    cxx_standard = {"": "c++17"},
+    extra_target_compatible_with = {
+        "": ["@//:cxx17"],
+    },
     llvm_versions = LLVM_VERSIONS,
     # We can share the downloaded LLVM distribution with the first configuration.
     toolchain_roots = {
@@ -106,6 +118,10 @@ llvm_toolchain(
 ## Toolchain example with system LLVM; tested in GitHub CI.
 llvm_toolchain(
     name = "llvm_toolchain_with_system_llvm",
+    cxx_standard = {"": "c++17"},
+    extra_target_compatible_with = {
+        "": ["@//:cxx17"],
+    },
     llvm_versions = LLVM_VERSIONS,
     # For this toolchain to work, the LLVM distribution archive would need to be unpacked here.
     toolchain_roots = {"": "/opt/llvm-16"},
@@ -129,6 +145,10 @@ filegroup(
 
 llvm_toolchain(
     name = "llvm_toolchain_with_sysroot",
+    cxx_standard = {"": "c++17"},
+    extra_target_compatible_with = {
+        "": ["@//:cxx17"],
+    },
     llvm_versions = LLVM_VERSIONS,
     sysroot = {
         "linux-x86_64": "@org_chromium_sysroot_linux_x64//:sysroot",
@@ -145,10 +165,14 @@ bazel_skylib_workspace()
 
 llvm_toolchain(
     name = "llvm_toolchain_linux_exec",
+    cxx_standard = {"": "c++17"},
     exec_arch = "amd64",
     # Option 2:
     # distribution = "clang+llvm-17.0.6-x86_64-linux-gnu-ubuntu-22.04.tar.xz",
     exec_os = "linux",
+    extra_target_compatible_with = {
+        "": ["@//:cxx17"],
+    },
     llvm_version = "17.0.6",
     # Option 1:
     sha256 = {"": "884ee67d647d77e58740c1e645649e29ae9e8a6fe87c1376be0f3a30f3cc9ab3"},
@@ -247,3 +271,16 @@ http_archive(
         "https://ftp.pcre.org/pub/pcre/pcre-8.43.tar.gz",
     ],
 )
+
+http_archive(
+    name = "platforms",
+    sha256 = "218efe8ee736d26a3572663b374a253c012b716d8af0c07e842e82f238a0a7ee",
+    urls = [
+        "https://mirror.bazel.build/github.com/bazelbuild/platforms/releases/download/0.0.10/platforms-0.0.10.tar.gz",
+        "https://github.com/bazelbuild/platforms/releases/download/0.0.10/platforms-0.0.10.tar.gz",
+    ],
+)
+
+load("@platforms//host:extension.bzl", "host_platform_repo")
+
+host_platform_repo(name = "host_platform")