Skip to content

Commit ed7cff6

Browse files
authored
Only emit sysroot warning when bazel is new enough (#613)
Otherwise, the warning leads to more warnings Fixes #611
1 parent 0feb868 commit ed7cff6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

toolchain/internal/system_module_map.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def _system_module_map(ctx):
8383
if len(sysroot_files) == 1:
8484
template_dict.add("%sysroot%", umbrella_submodule_closure(sysroot_files[0]))
8585
else:
86-
if sysroot_files:
86+
if sysroot_files and bazel_features.rules.merkle_cache_v2:
8787
# buildifier: disable=print
8888
print("WARNING: Sysroot {} resolved to {} files. Consider using the `sysroot` repository rule in @toolchains_llvm//toolchain:sysroot.bzl which provides a single-file (directory) sysroot for more efficient builds.".format(
8989
ctx.attr.sysroot_files.label,

0 commit comments

Comments
 (0)