Skip to content

Commit b1e23f1

Browse files
kyledobitzTim Malmströmoreflow
authored
Update WARNINGS.md (#1353)
* Update WARNINGS.md Include a link to a more detailed explanation of how to handle accumulating dependencies before constructing a depset. * Updating warnings.textproto and regenerating WARNINGS.md --------- Co-authored-by: Tim Malmström <[email protected]> Co-authored-by: Tim Malmström <[email protected]>
1 parent 04fb76e commit b1e23f1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

WARNINGS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,7 @@ When fixing this issue, make sure you
404404
[understand depsets](https://docs.bazel.build/versions/main/skylark/depsets.html)
405405
and try to
406406
[reduce the number of calls to depset](https://docs.bazel.build/versions/main/skylark/performance.html#reduce-the-number-of-calls-to-depset).
407+
See this [explanation](https://github.com/bazelbuild/bazel/issues/5817#issuecomment-496910826) for more detail.
407408

408409
--------------------------------------------------------------------------------
409410

warn/docs/warnings.textproto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,8 @@ warnings: {
223223
"When fixing this issue, make sure you\n"
224224
"[understand depsets](https://docs.bazel.build/versions/main/skylark/depsets.html)\n"
225225
"and try to\n"
226-
"[reduce the number of calls to depset](https://docs.bazel.build/versions/main/skylark/performance.html#reduce-the-number-of-calls-to-depset)."
226+
"[reduce the number of calls to depset](https://docs.bazel.build/versions/main/skylark/performance.html#reduce-the-number-of-calls-to-depset).\n"
227+
"See this [explanation](https://github.com/bazelbuild/bazel/issues/5817#issuecomment-496910826) for more detail."
227228
bazel_flag: "--incompatible_depset_union"
228229
bazel_flag_link: "https://github.com/bazelbuild/bazel/issues/5817"
229230
}

0 commit comments

Comments
 (0)