Skip to content

Initial query may return too many targets, sharding the sync when it's not needed #7799

@jmmv

Description

@jmmv

Description of the bug:

The IjwB aspect ignores targets marked as no-ide, and thus it "scales" with the number of targets that don't have the tag.

The initial query that the plugin issues does NOT filter out targets tagged as no-ide. The results of this query are used to determine if the sync process should be sharded, and because the list of targets may be inflated, the plugin may conclude that it needs to shard the sync when in reality that's not the case.

We see this in our project where we have a lot of "overhead" targets that we mark as no-ide and that the plugin doesn't care about, but they cause the sync to be sharded sometimes.

I've noticed that the query sync feature does this correctly already, so this is a matter of replicating the same filtering in the non-query-sync path.

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Create a project with a few java_library targets and tens of thousands of "noise targets" tagged as no-ide.

Which Intellij IDE are you using? Please provide the specific version.

No response

What programming languages and tools are you using? Please provide specific versions.

No response

What Bazel plugin version are you using?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Untriaged

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions