Skip to content

[spike] Use signal-based triggers #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[spike] Use signal-based triggers #303

wants to merge 2 commits into from

Conversation

@eirikbjornr
Copy link
Contributor

@eirikbjornr eirikbjornr commented Jun 28, 2023 •
edited
Loading

📺 What

Inject a signal object to use event-based triggers.

🛠 How

Create a DebugController with a signal (EventTarget). Trigger events in BSP through the controller.

👀 See

Video of using the debug controller to trigger a failover and manifest reload: https://www.dropbox.com/s/plbpazq6tllt5gs/badger-spike-signal-triggers.mov?dl=0

@eirikbjornr eirikbjornr added enhancement New feature or request semver minor This PR is a semver minor release labels Jun 28, 2023
@eirikbjornr eirikbjornr self-assigned this Jun 28, 2023
@eirikbjornr eirikbjornr requested a review from a team as a code owner June 28, 2023 15:41
markhouldridge
markhouldridge reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@markhouldridge markhouldridge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks interesting and found this while reviewing ticket, BADGER-77. Would be good to check if this is still something desired to improve debugging. I could see this being useful, e.g. forcing CDN failures from EPT, as an action button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markhouldridge markhouldridge markhouldridge left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@eirikbjornr eirikbjornr

Labels

enhancement New feature or request semver minor This PR is a semver minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eirikbjornr @markhouldridge