Just querying addressMinusSuffix for Address4 and why it's nilable? From what I can see, its definitely assigned in the constructor:
|
this.addressMinusSuffix = address; |
Perhaps I missed something though.
I'm assuming perhaps the constructor should actually complain before it parses the address if it's undefined, because if the provided address is undefined then there's no point continuing?
I'm running into a coverage issue in my library, as theoretically it won't ever be null which means I need to wrap the code in a check, either ?. or if (!a.addressMinusSuffix) which will never be exeuted, which means my coverage isn't 100%, which annoys me 😂
Just querying
addressMinusSuffixfor Address4 and why it's nilable? From what I can see, its definitely assigned in the constructor:ip-address/lib/ipv4.ts
Line 41 in b1df15f
Perhaps I missed something though.
I'm assuming perhaps the constructor should actually complain before it parses the address if it's undefined, because if the provided address is
undefinedthen there's no point continuing?I'm running into a coverage issue in my library, as theoretically it won't ever be
nullwhich means I need to wrap the code in a check, either?.orif (!a.addressMinusSuffix)which will never be exeuted, which means my coverage isn't 100%, which annoys me 😂