Remove ParseWebData dependency and refactor URL parsing

Eliminated usage of ParseWebData and related GCC diagnostic pragmas from http.cpp, http.cpp (webserver), and logic.cpp. Refactored get_first_bible_from_urls to manually parse query parameters, reducing external dependencies and simplifying code.
#1047

Author: teusbenschop

unittests/http.cpp

@@ -27,10 +27,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include <webserver/http.h>
 #include <webserver/request.h>
 #include <filter/url.h>
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Weffc++"
-#include <parsewebdata/ParseWebData.h>
-#pragma GCC diagnostic pop
 
 
 TEST (http, parse_host)
@@ -215,7 +211,7 @@ TEST (http, parse_post)
 }
 
 
-TEST (http, parse_header) // Todo
+TEST (http, parse_header)
 {
   // Test pstandard GET request.
   {

webserver/http.cpp

@@ -21,10 +21,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include <filter/url.h>
 #include <config/globals.h>
 #include <filter/string.h>
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Weffc++"
-#include <parsewebdata/ParseWebData.h>
-#pragma GCC diagnostic pop
 #include <webserver/request.h>
 #include <database/logs.h>
 

workspace/logic.cpp

@@ -34,10 +34,6 @@
 #include <database/logs.h>
 #include <database/cache.h>
 #include <read/index.h>
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Weffc++"
-#include <parsewebdata/ParseWebData.h>
-#pragma GCC diagnostic pop
 
 
 std::vector <std::string> workspace_get_default_names ()
@@ -582,18 +578,22 @@ std::map <int, int> workspace_add_bible_editor_number (std::map <int, std::strin
 }
 
 
+
+// Input: List of URLs like this: /a/b?bible=1&topbar=0
 std::optional<std::string> get_first_bible_from_urls (const std::map <int,std::string>& urls)
 {
   for (const auto& [key, url] : urls) {
     const std::vector <std::string> bits = filter::strings::explode (url, '?');
     if (bits.size() != 2)
       continue;
     if (!bits.at(1).empty ()) {
-      ParseWebData::WebDataMap web_data_map;
-      ParseWebData::parse_get_data (bits.at(1), web_data_map);
-      for (auto iter = web_data_map.cbegin(); iter != web_data_map.cend(); ++iter) {
-        if ((*iter).first == "bible")
-          return filter_url_urldecode ((*iter).second.value);
+      // Explode the data on the ampersand ( & ) and then on the equal sign ( = ).
+      std::vector<std::string> keys_values = filter::strings::explode(bits.at(1), '&');
+      for (const auto& fragment : keys_values) {
+        std::vector<std::string> key_value = filter::strings::explode(fragment, '=');
+        if (key_value.size() == 2)
+          if (key_value.at(0) == "bible")
+            return filter_url_urldecode (key_value.at(1));
       }
     }
   }