Rename http_parse_post_v2 to http_parse_post

Replaces all usages and declarations of http_parse_post_v2 with http_parse_post for consistency and clarity. No functional changes were made; this is a refactor to simplify the function name.
#1052

Author: teusbenschop

unittests/http.cpp

@@ -68,7 +68,7 @@ TEST (http, parse_post)
       container standard = {
         {"key", "value"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
     {
@@ -77,7 +77,7 @@ TEST (http, parse_post)
         {"key1", "value1"},
         {"key2", "value2"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
     {
@@ -86,23 +86,23 @@ TEST (http, parse_post)
         {"key1", ""},
         {"key2", ""},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
     {
       const std::string posted {"key=Hello+World"};
       container standard = {
         {"key", "Hello World"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
     {
       const std::string posted {"key=H%C3%ABllo+W%C3%B6rld"};
       container standard = {
         {"key", "Hëllo Wörld"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
   }
@@ -117,7 +117,7 @@ TEST (http, parse_post)
       container standard = {
         {"key", "value"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
 
@@ -130,7 +130,7 @@ TEST (http, parse_post)
         {"key1", "value1"},
         {"key2", "value2"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
 
@@ -143,7 +143,7 @@ TEST (http, parse_post)
         {"key1", ""},
         {"key2", ""},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
 
@@ -154,7 +154,7 @@ TEST (http, parse_post)
       container standard = {
         {"key", "Hello World"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
 
@@ -165,7 +165,7 @@ TEST (http, parse_post)
       container standard = {
         {"key", "Hëllo Wörld"},
       };
-      http_parse_post_v2 (posted, webserver_request);
+      http_parse_post (posted, webserver_request);
       EXPECT_EQ(standard, webserver_request.post);
     }
   }
@@ -181,7 +181,7 @@ TEST (http, parse_post)
         const std::string content = filter_url_file_get_contents(test_path + "http-post-1.txt");
         Webserver_Request webserver_request{};
         webserver_request.content_type = content_type;
-        http_parse_post_v2 (content, webserver_request);
+        http_parse_post (content, webserver_request);
         const container standard_new {
           {"filename", "00_test1.txt"},
           {"data", "Contents for test1.\nLine one 1.\nLine two 1.\nLine three 1.\n"},
@@ -195,7 +195,7 @@ TEST (http, parse_post)
       const std::string content = filter_url_file_get_contents(test_path + "http-post-2.txt");
       Webserver_Request webserver_request{};
       webserver_request.content_type = content_type;
-      http_parse_post_v2 (content, webserver_request);
+      http_parse_post (content, webserver_request);
       const container standard {
         {"filename", "00_test1.txt"},
         {"data", "Contents for test1.\nLine one 1.\nLine two 1.\nLine three 1.\n"},

webserver/http.cpp

@@ -157,7 +157,7 @@ bool http_parse_header (std::string header, Webserver_Request& webserver_request
 
 
 // Takes data POSTed from the browser, and parses it.
-void http_parse_post_v2 (std::string content, Webserver_Request& webserver_request)
+void http_parse_post (std::string content, Webserver_Request& webserver_request)
 {
   // If there's no content, there's nothing to parse: Done.
   if (content.empty ())

webserver/http.h

@@ -28,7 +28,7 @@ constexpr const char* text_plain {"text/plain"};
 constexpr const char* multipart_form_data {"multipart/form-data"};
 
 bool http_parse_header (std::string header, Webserver_Request& webserver_request);
-void http_parse_post_v2 (std::string content, Webserver_Request& webserver_request);
+void http_parse_post (std::string content, Webserver_Request& webserver_request);
 void http_assemble_response (Webserver_Request& webserver_request);
 void http_stream_file (Webserver_Request& webserver_request, bool enable_cache);
 std::string http_parse_host (const std::string & line);

webserver/webserver.cpp

@@ -220,7 +220,7 @@ static void webserver_process_request (const int connfd, const std::string& clie
 
         if (connection_healthy) {
 
-          http_parse_post_v2 (postdata, request);
+          http_parse_post (postdata, request);
 
           // Assemble response.
           bootstrap_index (request);
@@ -683,7 +683,7 @@ static void secure_webserver_process_request (mbedtls_ssl_config * conf, mbedtls
         if (total_bytes_read < request.content_length) connection_healthy = false;
         // Parse the POSTed data.
         if (connection_healthy) {
-          http_parse_post_v2 (postdata, request);
+          http_parse_post (postdata, request);
         }
       }