-
Notifications
You must be signed in to change notification settings - Fork 316
Closed
Labels
Milestone
Description
Continued from #1157. We should:
- Do a review pass and make some of the
AlignmentRecordConvertermethods private - Make
SAMFileHeaderWritableprivate to ADAM, and change theAlignmentRecordConverter.convertsignature to take aSAMFileHeader
Also, contributed for discussion by @heuermh:
Also, I think it's more useful to have the conversion utility at the record level, rather than the RDD level, since then it can be used outside Spark.
If that were the case, it would be preferable to me to have the conversion stuff written in Java instead of Scala and be a library external to ADAM.