Skip to content

Clean up packaging of conversion methods #1170

@fnothaft

Description

@fnothaft

Continued from #1157. We should:

  • Do a review pass and make some of the AlignmentRecordConverter methods private
  • Make SAMFileHeaderWritable private to ADAM, and change the AlignmentRecordConverter.convert signature to take a SAMFileHeader

Also, contributed for discussion by @heuermh:

Also, I think it's more useful to have the conversion utility at the record level, rather than the RDD level, since then it can be used outside Spark.

If that were the case, it would be preferable to me to have the conversion stuff written in Java instead of Scala and be a library external to ADAM.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions