Skip to content

Commit 9ac3bcc

Browse files
committed
Improve examples: remove key generation loops
1 parent 1988855 commit 9ac3bcc

File tree

3 files changed

+18
-24
lines changed

3 files changed

+18
-24
lines changed

examples/ecdh.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,12 @@ int main(void) {
4646
/* If the secret key is zero or out of range (bigger than secp256k1's
4747
* order), we try to sample a new key. Note that the probability of this
4848
* happening is negligible. */
49-
while (1) {
50-
if (!fill_random(seckey1, sizeof(seckey1)) || !fill_random(seckey2, sizeof(seckey2))) {
51-
printf("Failed to generate randomness\n");
52-
return 1;
53-
}
54-
if (secp256k1_ec_seckey_verify(ctx, seckey1) && secp256k1_ec_seckey_verify(ctx, seckey2)) {
55-
break;
56-
}
49+
if (!fill_random(seckey1, sizeof(seckey1)) || !fill_random(seckey2, sizeof(seckey2))) {
50+
printf("Failed to generate randomness\n");
51+
return 1;
52+
}
53+
if (secp256k1_ec_seckey_verify(ctx, seckey1) && secp256k1_ec_seckey_verify(ctx, seckey2)) {
54+
break;
5755
}
5856

5957
/* Public key creation using a valid context with a verified secret key should never fail */

examples/ecdsa.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,12 @@ int main(void) {
5353
/* If the secret key is zero or out of range (bigger than secp256k1's
5454
* order), we try to sample a new key. Note that the probability of this
5555
* happening is negligible. */
56-
while (1) {
57-
if (!fill_random(seckey, sizeof(seckey))) {
58-
printf("Failed to generate randomness\n");
59-
return 1;
60-
}
61-
if (secp256k1_ec_seckey_verify(ctx, seckey)) {
62-
break;
63-
}
56+
if (!fill_random(seckey, sizeof(seckey))) {
57+
printf("Failed to generate randomness\n");
58+
return 1;
59+
}
60+
if (secp256k1_ec_seckey_verify(ctx, seckey)) {
61+
break;
6462
}
6563

6664
/* Public key creation using a valid context with a verified secret key should never fail */

examples/ellswift.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,12 @@ int main(void) {
5151
/* If the secret key is zero or out of range (bigger than secp256k1's
5252
* order), we try to sample a new key. Note that the probability of this
5353
* happening is negligible. */
54-
while (1) {
55-
if (!fill_random(seckey1, sizeof(seckey1)) || !fill_random(seckey2, sizeof(seckey2))) {
56-
printf("Failed to generate randomness\n");
57-
return 1;
58-
}
59-
if (secp256k1_ec_seckey_verify(ctx, seckey1) && secp256k1_ec_seckey_verify(ctx, seckey2)) {
60-
break;
61-
}
54+
if (!fill_random(seckey1, sizeof(seckey1)) || !fill_random(seckey2, sizeof(seckey2))) {
55+
printf("Failed to generate randomness\n");
56+
return 1;
57+
}
58+
if (secp256k1_ec_seckey_verify(ctx, seckey1) && secp256k1_ec_seckey_verify(ctx, seckey2)) {
59+
break;
6260
}
6361

6462
/* Generate ElligatorSwift public keys. This should never fail with valid context and

0 commit comments

Comments
 (0)