[bitnami/redis] Service binding gives wrong password

[yanghanlin]

Name and Version

bitnami/redis:17.8.5

What architecture are you using?

None

What steps will reproduce the bug?

Deploy an instance of bitnami/redis with no password set (leaving password generation to this chart) and service bindings enabled:

helm install redis bitnami/redis --set serviceBindings.enabled=true

Inspect the passwords provided by secret redis and secret redis-svcbind (service binding):

kubectl get secrets/redis -o json | jq -r '.data["redis-password"] | @base64d' # output: DANNl007Cc
kubectl get secrets/redis-svcbind -o json | jq -r '.data.password | @base64d' # output: Pozxyif8SK

Are you using any custom parameters or values?

No response

What is the expected behavior?

Passwords provided by secrets redis and redis-svcbind are consistent and both correct.

What do you see instead?

The password provided by secret redis-svcbind (the service binding) is not correct.

Additional information

I believe that I have found the cause of this issue. In this file, the password of Redis instance/cluster being created is generated and assigned to $password:

charts/bitnami/redis/templates/secret.yaml

Line 9 in 452088f

{{- $password := include "redis.password" . }}

However, when creating the secret redis, the password is generated again:

charts/bitnami/redis/templates/secret.yaml

Line 32 in 452088f

redis-password: {{ include "redis.password" . | b64enc | quote }}

[javsalgar]

Hi!

Thank you so much for reporting! Indeed, the line should be:

  redis-password: {{ print $password | b64enc | quote }}

Would you like to submit a PR with the fix?

[yanghanlin]

Hi!

Thank you so much for reporting! Indeed, the line should be:

  redis-password: {{ print $password | b64enc | quote }}

Would you like to submit a PR with the fix?

@javsalgar Thanks for your reply. I have proposed a PR #15672 and have verified such changes fix this issue.

[carrodher]

Thanks for creating this issue and the associated PR. The team will review it and provide feedback. Once merged the PR, this issue will be automatically closed.

[yuvaltabnine]

I'm seeing this exact same problem in 20.11.3