Skip to content

Commit b578e76

Browse files
fmulerocarrodher
andauthored
chore(node): Bump node version (#124)
* chore(node): Bump node version Signed-off-by: Fran Mulero <[email protected]> * Update render.js making linter happy Signed-off-by: Carlos Rodríguez Hernández <[email protected]> --------- Signed-off-by: Fran Mulero <[email protected]> Signed-off-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]>
1 parent 430856f commit b578e76

File tree

7 files changed

+2697
-5950
lines changed

7 files changed

+2697
-5950
lines changed

.github/workflows/cd-pipeline.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- name: Checkout repository
14-
uses: actions/checkout@v4
14+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
1515
# Setup .npmrc file to publish to npm
1616
- name: Setup Node.js
17-
uses: actions/setup-node@v4
17+
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af
1818
with:
19-
node-version: '16.x'
19+
node-version: '22.x'
2020
registry-url: 'https://registry.npmjs.org'
2121
scope: '@bitnami'
2222
- name: Cache dependencies
23-
uses: actions/cache@v4
23+
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57
2424
with:
2525
path: ~/.npm
2626
key: npm-${{ hashFiles('package-lock.json') }}

.github/workflows/ci-pipeline.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- name: Checkout repository
17-
uses: actions/checkout@v4
17+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
1818
- name: Setup Node.js
19-
uses: actions/setup-node@v4
19+
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af
2020
with:
21-
node-version: '16.x'
21+
node-version: '22.x'
2222
- name: Cache dependencies
23-
uses: actions/cache@v4
23+
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57
2424
with:
2525
path: ~/.npm
2626
key: npm-${{ hashFiles('package-lock.json') }}

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Copyright Broadcom, Inc. All Rights Reserved.
33
# SPDX-License-Identifier: Apache-2.0
44
#
5-
FROM bitnami/node:16
5+
FROM bitnami/node:22
66

77
LABEL org.opencontainers.image.authors="https://bitnami.com/contact" \
88
org.opencontainers.image.description="Readme Generator For Helm" \

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ The number of `#` characters needed for the section titles is dynamically calcul
3737

3838
## Requirements
3939

40-
The project has been developed and tested with node version `16.x`.
40+
The project has been developed and tested with node version `22.x`.
4141

4242
## Install
4343

@@ -58,7 +58,7 @@ Execute the following commands to create a single executable binary for the tool
5858
git clone https://github.com/bitnami/readme-generator-for-helm
5959
cd ./readme-generator-for-helm
6060
npm install
61-
npm install -g pkg
61+
npm install -g @yao-pkg/pkg
6262
pkg . -o readme-generator-for-helm
6363
```
6464

lib/render.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ function insertReadmeTable(readmeFilePath, sections, config) {
9999
}
100100
// Detect last table-like line bottom to top to ignore description text between tables
101101
let lastTableLikeLineFound = false;
102-
const endParamsSectionRegExp = new RegExp('(?!.*\\|).*\\S(?<!\\|.*)(?<!#.*)'); // Match non empty or with non table format lines
102+
const endParamsSectionRegExp = /(?!.*\|).*\S(?<!\|.*)(?<!#.*)/; // Match non empty or with non table format lines
103103
lines.slice(paramsSectionLimits[0], paramsSectionLimits[1]).reverse().forEach((line, i) => {
104104
if (!lastTableLikeLineFound && line && !line.match(endParamsSectionRegExp)) {
105105
lastTableLikeLineFound = true;

0 commit comments

Comments
 (0)