[PM-27246] Update Authenticator to use ActionCard (#2123)

Author: matt-livefront

AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListCardView+SnapshotTests.swift

@@ -43,7 +43,7 @@ class ItemListViewTests: BitwardenTestCase {
 
     /// Test the close taps trigger the associated effect.
     @MainActor
-    func test_itemListCardView_close_download() throws {
+    func test_actionCard_close_download() async throws {
         let state = ItemListState(
             itemListCardState: .passwordManagerDownload,
             loadingState: .data([ItemListSection.fixture()]),
@@ -54,16 +54,15 @@ class ItemListViewTests: BitwardenTestCase {
             timeProvider: timeProvider,
         )
 
-        try subject.inspect().find(buttonWithAccessibilityLabel: Localizations.close).tap()
-
-        waitFor(!processor.effects.isEmpty)
+        let actionCard = try subject.inspect().find(actionCard: Localizations.downloadTheBitwardenApp)
+        try await actionCard.find(asyncButton: Localizations.close).tap()
 
         XCTAssertEqual(processor.effects.last, .closeCard(.passwordManagerDownload))
     }
 
     /// Test the close taps trigger the associated effect.
     @MainActor
-    func test_itemListCardView_close_sync() throws {
+    func test_actionCard_close_sync() async throws {
         let state = ItemListState(
             itemListCardState: .passwordManagerSync,
             loadingState: .data([]),
@@ -74,9 +73,8 @@ class ItemListViewTests: BitwardenTestCase {
             timeProvider: timeProvider,
         )
 
-        try subject.inspect().find(buttonWithAccessibilityLabel: Localizations.close).tap()
-
-        waitFor(!processor.effects.isEmpty)
+        let actionCard = try subject.inspect().find(actionCard: Localizations.syncWithTheBitwardenApp)
+        try await actionCard.find(asyncButton: Localizations.close).tap()
 
         XCTAssertEqual(processor.effects.last, .closeCard(.passwordManagerSync))
     }

AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListCardView+ViewInspectorTests.swift

@@ -7,7 +7,7 @@ import SwiftUI
 // MARK: - SearchableItemListView
 
 /// A view that displays the items in a single vault group.
-private struct SearchableItemListView: View { // swiftlint:disable:this type_body_length
+private struct SearchableItemListView: View {
     // MARK: Properties
 
     /// A flag indicating if the search bar is focused.
@@ -131,52 +131,42 @@ private struct SearchableItemListView: View { // swiftlint:disable:this type_bod
 
     /// The Password Manager download card definition.
     private var itemListCardPasswordManagerInstall: some View {
-        ItemListCardView(
-            bodyText: Localizations.storeAllOfYourLoginsAndSyncVerificationCodesDirectlyWithTheAuthenticatorApp,
-            buttonText: Localizations.downloadTheBitwardenApp,
-            leftImage: {
-                Image(decorative: SharedAsset.Icons.shield24)
-                    .foregroundColor(Asset.Colors.primaryBitwardenLight.swiftUIColor)
-                    .frame(width: 24, height: 24)
-            },
-            titleText: Localizations.downloadTheBitwardenApp,
-            actionTapped: {
+        ActionCard(
+            title: Localizations.downloadTheBitwardenApp,
+            message: Localizations.storeAllOfYourLoginsAndSyncVerificationCodesDirectlyWithTheAuthenticatorApp,
+            actionButtonState: ActionCard.ButtonState(title: Localizations.downloadTheBitwardenApp) {
                 openURL(ExternalLinksConstants.passwordManagerLink)
             },
-            closeTapped: {
-                Task {
-                    await store.perform(.closeCard(.passwordManagerDownload))
-                }
+            dismissButtonState: ActionCard.ButtonState(title: Localizations.close) {
+                await store.perform(.closeCard(.passwordManagerDownload))
             },
-        )
+        ) {
+            Image(decorative: SharedAsset.Icons.shield24)
+                .foregroundColor(SharedAsset.Colors.iconSecondary.swiftUIColor)
+                .frame(width: 24, height: 24)
+        }
         .padding(.top, 16)
     }
 
     /// The Password Manager sync card definition.
     private var itemListCardSync: some View {
-        ItemListCardView(
-            bodyText: Localizations
-                .allowAuthenticatorAppSyncingInSettingsToViewAllYourVerificationCodesHere,
-            buttonText: Localizations.takeMeToTheAppSettings,
-            leftImage: {
-                Image(decorative: SharedAsset.Icons.arrowSync24)
-                    .foregroundColor(Asset.Colors.primaryBitwardenLight.swiftUIColor)
-                    .frame(width: 24, height: 24)
-            },
-            secondaryButtonText: Localizations.learnMore,
-            titleText: Localizations.syncWithTheBitwardenApp,
-            actionTapped: {
+        ActionCard(
+            title: Localizations.syncWithTheBitwardenApp,
+            message: Localizations.allowAuthenticatorAppSyncingInSettingsToViewAllYourVerificationCodesHere,
+            actionButtonState: ActionCard.ButtonState(title: Localizations.takeMeToTheAppSettings) {
                 openURL(ExternalLinksConstants.passwordManagerSettings)
             },
-            closeTapped: {
-                Task {
-                    await store.perform(.closeCard(.passwordManagerSync))
-                }
+            dismissButtonState: ActionCard.ButtonState(title: Localizations.close) {
+                await store.perform(.closeCard(.passwordManagerSync))
             },
-            secondaryActionTapped: {
+            secondaryButtonState: ActionCard.ButtonState(title: Localizations.learnMore) {
                 openURL(ExternalLinksConstants.totpSyncHelp)
             },
-        )
+        ) {
+            Image(decorative: SharedAsset.Icons.arrowSync24)
+                .foregroundColor(SharedAsset.Colors.iconSecondary.swiftUIColor)
+                .frame(width: 24, height: 24)
+        }
         .padding(.top, 16)
     }
 
@@ -722,6 +712,36 @@ struct ItemListView_Previews: PreviewProvider { // swiftlint:disable:this type_b
                 timeProvider: PreviewTimeProvider(),
             )
         }.previewDisplayName("SharedItems")
+
+        NavigationView {
+            ItemListView(
+                store: Store(
+                    processor: StateProcessor(
+                        state: ItemListState(
+                            itemListCardState: .passwordManagerDownload,
+                            loadingState: .data([]),
+                        ),
+                    ),
+                ),
+                timeProvider: PreviewTimeProvider(),
+            )
+        }
+        .previewDisplayName("Password Manager Download Card")
+
+        NavigationView {
+            ItemListView(
+                store: Store(
+                    processor: StateProcessor(
+                        state: ItemListState(
+                            itemListCardState: .passwordManagerSync,
+                            loadingState: .data([]),
+                        ),
+                    ),
+                ),
+                timeProvider: PreviewTimeProvider(),
+            )
+        }
+        .previewDisplayName("Password Manager Sync Card")
     }
 }
 #endif