From 5fde4fa13cfc1d21c28a066954f7a25a81cd374f Mon Sep 17 00:00:00 2001 From: Andrey Parfenov Date: Thu, 1 May 2025 23:17:50 +0200 Subject: [PATCH 1/4] swap ubuntu runners to latest to fix CI issues with deprecation Signed-off-by: Andrey Parfenov --- .github/workflows/run_libftdi.yml | 4 ++-- .github/workflows/run_matlab.yml | 2 +- .github/workflows/run_unix.yml | 16 ++++++++-------- .github/workflows/valgrind.yml | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/run_libftdi.yml b/.github/workflows/run_libftdi.yml index 49c9b8f48..c9f86c03f 100644 --- a/.github/workflows/run_libftdi.yml +++ b/.github/workflows/run_libftdi.yml @@ -10,7 +10,7 @@ jobs: fail-fast: false max-parallel: 4 matrix: - os: [ubuntu-20.04] + os: [ubuntu-latest] steps: # compile and prepare env @@ -22,7 +22,7 @@ jobs: python-version: '3.7.7' architecture: 'x64' - name: Install Ubuntu Dependencies - if: (matrix.os == 'ubuntu-20.04') + if: (matrix.os == 'ubuntu-latest') run: | sudo -H apt-get update -y sudo -H apt-get install -y python3-setuptools python3-pygments libftdi1-dev diff --git a/.github/workflows/run_matlab.yml b/.github/workflows/run_matlab.yml index 3cbd903fc..b2000f219 100644 --- a/.github/workflows/run_matlab.yml +++ b/.github/workflows/run_matlab.yml @@ -5,7 +5,7 @@ on: [push, pull_request] jobs: RunMatlabLinux: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest steps: - name: Check out repository diff --git a/.github/workflows/run_unix.yml b/.github/workflows/run_unix.yml index 1c7a3d336..a9c6060ca 100644 --- a/.github/workflows/run_unix.yml +++ b/.github/workflows/run_unix.yml @@ -10,7 +10,7 @@ jobs: fail-fast: false max-parallel: 4 matrix: - os: [ubuntu-20.04, macos-13] + os: [ubuntu-latest, macos-13] steps: # compile and prepare env @@ -31,7 +31,7 @@ jobs: python-version: '3.7.7' architecture: 'x64' - name: Install Python Dependencies - if: (matrix.os == 'ubuntu-20.04') + if: (matrix.os == 'ubuntu-latest') run: | sudo -H apt-get update -y sudo -H apt-get install -y python3-setuptools python3-pygments libbluetooth-dev @@ -81,7 +81,7 @@ jobs: env: BRAINFLOW_VERSION: ${{ steps.version.outputs.version }} - name: Compile BrainFlow Ubuntu - if: (matrix.os == 'ubuntu-20.04') + if: (matrix.os == 'ubuntu-latest') run: | mkdir $GITHUB_WORKSPACE/build cd $GITHUB_WORKSPACE/build @@ -92,7 +92,7 @@ jobs: BRAINFLOW_VERSION: ${{ steps.version.outputs.version }} - name: Compile BrainFlow in ManyLinux # bindings in production have to use libraries compiled inside this image! - if: (matrix.os == 'ubuntu-20.04') + if: (matrix.os == 'ubuntu-latest') run: | docker pull dockcross/manylinux_2_28-x64:20240418-88c04a4 docker run -e BRAINFLOW_VERSION=$BRAINFLOW_VERSION -e GITHUB_WORKSPACE=$GITHUB_WORKSPACE -v $GITHUB_WORKSPACE:$GITHUB_WORKSPACE dockcross/manylinux_2_28-x64:20240418-88c04a4 /bin/bash -c "yum install -y bluez-libs-devel dbus-devel && /opt/python/cp36-cp36m/bin/pip3.6 install cmake==3.21.4 && cd $GITHUB_WORKSPACE && mkdir build_docker && cd build_docker && /opt/_internal/cpython-3.6.15/bin/cmake -DBRAINFLOW_VERSION=$BRAINFLOW_VERSION -DBUILD_ONNX=ON -DBUILD_BLE=ON -DBUILD_BLUETOOTH=ON -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/installed_docker -DCMAKE_BUILD_TYPE=Release .. && make && make install" @@ -176,7 +176,7 @@ jobs: LD_LIBRARY_PATH: ${{ github.workspace }}/installed/lib DYLD_LIBRARY_PATH: ${{ github.workspace }}/installed/lib - name: Synthetic C# Test Ubuntu - if: (matrix.os == 'ubuntu-20.04') + if: (matrix.os == 'ubuntu-latest') run: | cd $GITHUB_WORKSPACE/csharp_package/brainflow/examples/brainflow_get_data/bin/Release/net7.0 ./brainflow_get_data --board-id -1 @@ -185,7 +185,7 @@ jobs: LD_LIBRARY_PATH: ${{ github.workspace }}/installed/lib DYLD_LIBRARY_PATH: ${{ github.workspace }}/installed/lib - name: EEG Metrics C# Test Ubuntu - if: (matrix.os == 'ubuntu-20.04') + if: (matrix.os == 'ubuntu-latest') run: | cd $GITHUB_WORKSPACE/csharp_package/brainflow/examples/eeg_metrics/bin/Release/net7.0 ./eeg_metrics --board-id -1 @@ -364,7 +364,7 @@ jobs: env: LD_LIBRARY_PATH: ${{ github.workspace }}/installed/lib - name: EEG Metrics Cpp Dyn Lib - if: (matrix.os == 'ubuntu-20.04') + if: (matrix.os == 'ubuntu-latest') run: $GITHUB_WORKSPACE/cpp_package/examples/ml/build/eeg_metrics_ci --board-id -1 --metric 2 --classifier 1 --model-file $GITHUB_WORKSPACE/cpp_package/examples/ml/build/libdyn_lib_test.so env: LD_LIBRARY_PATH: ${{ github.workspace }}/installed/lib @@ -406,7 +406,7 @@ jobs: - name: Install AWS CLI run: sudo -H python3 -m pip install awscli==1.21.10 - name: Push Libraries Linux Docker - if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-20.04' && github.repository == 'brainflow-dev/brainflow' }} + if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && github.repository == 'brainflow-dev/brainflow' }} run: | aws s3 cp $GITHUB_WORKSPACE/installed_docker/lib/ s3://brainflow/$GITHUB_SHA/linux --recursive env: diff --git a/.github/workflows/valgrind.yml b/.github/workflows/valgrind.yml index 205da45c3..420408d76 100644 --- a/.github/workflows/valgrind.yml +++ b/.github/workflows/valgrind.yml @@ -10,7 +10,7 @@ jobs: fail-fast: false max-parallel: 4 matrix: - os: [ubuntu-20.04] + os: [ubuntu-latest] steps: # compile and prepare env From 3d7ec7cdaa58ef1debdb1d4880b28390bb4665d9 Mon Sep 17 00:00:00 2001 From: Andrey Parfenov Date: Fri, 2 May 2025 00:24:10 +0200 Subject: [PATCH 2/4] fixing ci Signed-off-by: Andrey Parfenov --- .github/workflows/run_libftdi.yml | 7 +++---- .github/workflows/run_matlab.yml | 14 +++++++------- .github/workflows/run_unix.yml | 7 +++---- .github/workflows/valgrind.yml | 7 +++---- 4 files changed, 16 insertions(+), 19 deletions(-) diff --git a/.github/workflows/run_libftdi.yml b/.github/workflows/run_libftdi.yml index c9f86c03f..7a27db389 100644 --- a/.github/workflows/run_libftdi.yml +++ b/.github/workflows/run_libftdi.yml @@ -16,11 +16,10 @@ jobs: # compile and prepare env - name: Clone Repository uses: actions/checkout@v2 - - name: Install Python 3.7 - uses: actions/setup-python@v3 + - name: Install Python 3.10 + uses: actions/setup-python@v5 with: - python-version: '3.7.7' - architecture: 'x64' + python-version: '3.11' - name: Install Ubuntu Dependencies if: (matrix.os == 'ubuntu-latest') run: | diff --git a/.github/workflows/run_matlab.yml b/.github/workflows/run_matlab.yml index b2000f219..0f4f46630 100644 --- a/.github/workflows/run_matlab.yml +++ b/.github/workflows/run_matlab.yml @@ -22,28 +22,28 @@ jobs: make make install - name: Set up Matlab - uses: matlab-actions/setup-matlab@v1 + uses: matlab-actions/setup-matlab@v2 - name: Run Signal Processing Test - uses: matlab-actions/run-command@v1 + uses: matlab-actions/run-command@v2 with: command: addpath('matlab_package/brainflow'),addpath('matlab_package/brainflow/examples'),addpath('matlab_package/brainflow/inc'),addpath('matlab_package/brainflow/lib'),SignalFiltering - name: Run Transforms Test - uses: matlab-actions/run-command@v1 + uses: matlab-actions/run-command@v2 with: command: addpath('matlab_package/brainflow'),addpath('matlab_package/brainflow/examples'),addpath('matlab_package/brainflow/inc'),addpath('matlab_package/brainflow/lib'),Transforms - name: Run EEG Mertrics Test - uses: matlab-actions/run-command@v1 + uses: matlab-actions/run-command@v2 with: command: addpath('matlab_package/brainflow'),addpath('matlab_package/brainflow/examples'),addpath('matlab_package/brainflow/inc'),addpath('matlab_package/brainflow/lib'),EEGMetrics - name: Run CSP Test - uses: matlab-actions/run-command@v1 + uses: matlab-actions/run-command@v2 with: command: addpath('matlab_package/brainflow'),addpath('matlab_package/brainflow/examples'),addpath('matlab_package/brainflow/inc'),addpath('matlab_package/brainflow/lib'),CSP - name: Run Spo2 Test - uses: matlab-actions/run-command@v1 + uses: matlab-actions/run-command@v2 with: command: addpath('matlab_package/brainflow'),addpath('matlab_package/brainflow/examples'),addpath('matlab_package/brainflow/inc'),addpath('matlab_package/brainflow/lib'),Spo2 - name: Run ICA Test - uses: matlab-actions/run-command@v1 + uses: matlab-actions/run-command@v2 with: command: addpath('matlab_package/brainflow'),addpath('matlab_package/brainflow/examples'),addpath('matlab_package/brainflow/inc'),addpath('matlab_package/brainflow/lib'),ICA diff --git a/.github/workflows/run_unix.yml b/.github/workflows/run_unix.yml index a9c6060ca..87398190d 100644 --- a/.github/workflows/run_unix.yml +++ b/.github/workflows/run_unix.yml @@ -25,11 +25,10 @@ jobs: uses: actions/setup-dotnet@v3 with: dotnet-version: '7.0.x' - - name: Install Python 3.7 - uses: actions/setup-python@v3 + - name: Install Python 3.10 + uses: actions/setup-python@v5 with: - python-version: '3.7.7' - architecture: 'x64' + python-version: '3.11' - name: Install Python Dependencies if: (matrix.os == 'ubuntu-latest') run: | diff --git a/.github/workflows/valgrind.yml b/.github/workflows/valgrind.yml index 420408d76..b374d4c71 100644 --- a/.github/workflows/valgrind.yml +++ b/.github/workflows/valgrind.yml @@ -60,11 +60,10 @@ jobs: sudo -H apt-get install -y valgrind env: DEBIAN_FRONTEND: noninteractive - - name: Install Python 3.7 - uses: actions/setup-python@v3 + - name: Install Python 3.10 + uses: actions/setup-python@v5 with: - python-version: '3.7.7' - architecture: 'x64' + python-version: '3.11' - name: Install Python Dependencies run: | sudo -H apt-get update -y From 5a4f3a7fe39ee720231a3106b70c728c954de480 Mon Sep 17 00:00:00 2001 From: Andrey Parfenov Date: Fri, 2 May 2025 01:43:55 +0200 Subject: [PATCH 3/4] fixing ci Signed-off-by: Andrey Parfenov --- .github/workflows/run_matlab.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run_matlab.yml b/.github/workflows/run_matlab.yml index 0f4f46630..ece48d78b 100644 --- a/.github/workflows/run_matlab.yml +++ b/.github/workflows/run_matlab.yml @@ -5,7 +5,7 @@ on: [push, pull_request] jobs: RunMatlabLinux: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Check out repository From f958870326fe3d2652e39a2dc7c826ab898b5e0b Mon Sep 17 00:00:00 2001 From: Andrey Parfenov Date: Fri, 2 May 2025 02:35:50 +0200 Subject: [PATCH 4/4] fixing ci Signed-off-by: Andrey Parfenov --- .github/workflows/run_unix.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run_unix.yml b/.github/workflows/run_unix.yml index 87398190d..57e9a232c 100644 --- a/.github/workflows/run_unix.yml +++ b/.github/workflows/run_unix.yml @@ -403,7 +403,7 @@ jobs: npm run bandpower_all # deploy started - name: Install AWS CLI - run: sudo -H python3 -m pip install awscli==1.21.10 + run: sudo -H python3 -m pip install awscli - name: Push Libraries Linux Docker if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && github.repository == 'brainflow-dev/brainflow' }} run: |