Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

Commit 0cb444b

Browse files
roberthebelmnelemans
andcommitted
fix: production builds using webpack
Co-authored-by: mnelemans <[email protected]>
1 parent 60df12c commit 0cb444b

File tree

4 files changed

+14
-8
lines changed

4 files changed

+14
-8
lines changed

cypress/integration/Arrows.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,17 @@ describe('Arrows', () => {
1111
it('changes slide when clicks on the arrow', () => {
1212
cy.get('.BrainhubCarousel__arrowRight').trigger('click');
1313

14+
cy.wait(1);
15+
1416
cy.get('.BrainhubCarouselItem--active')
1517
.children('img')
1618
.should('have.attr', 'src')
1719
.and('contain', 'scream');
1820

1921
cy.get('.BrainhubCarousel__arrowLeft').trigger('click');
2022

23+
cy.wait(1);
24+
2125
cy.get('.BrainhubCarouselItem--active')
2226
.children('img')
2327
.should('have.attr', 'src')
@@ -27,6 +31,7 @@ describe('Arrows', () => {
2731
it(`doesn't allow to click on the arrow if there is no more slides`, () => {
2832
for (let i = 0; i < 2; i++) {
2933
cy.get('.BrainhubCarousel__arrowRight').trigger('click');
34+
cy.wait(1);
3035
}
3136

3237
cy.get('.BrainhubCarouselItem--active')

react-carousel/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,9 @@
5151
"node-sass": "^4.13.1",
5252
"postcss-loader": "^3.0.0",
5353
"prop-types": "^15.7.2",
54-
"react": "^16.13.1",
55-
"react-dom": "^16.13.1",
5654
"react-resize-detector": "^5.0.6",
5755
"react-test-renderer": "^16.13.1",
58-
"recoil": "^0.0.10",
56+
"recoil": "^0.0.13",
5957
"resize-observer-polyfill": "^1.5.1",
6058
"rimraf": "3.0.2",
6159
"sass-loader": "^8.0.2",

react-carousel/webpack.config.prod.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const autoprefixer = require('autoprefixer');
66
const ExtractTextPlugin = require('extract-text-webpack-plugin');
77

88
module.exports = {
9+
mode: 'production',
910
externals: [
1011
{
1112
'react-dom': {
@@ -48,7 +49,9 @@ module.exports = {
4849
new ExtractTextPlugin('style.css'),
4950
new webpack.DefinePlugin({
5051
// This fixes https://github.com/brainhubeu/react-carousel/issues/115
51-
'process.env.NODE_ENV': process.env.NODE_ENV,
52+
'process.env': {
53+
NODE_ENV: JSON.stringify('production'),
54+
},
5255
}),
5356
],
5457
module: {

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17199,10 +17199,10 @@ realpath-native@^1.1.0:
1719917199
dependencies:
1720017200
util.promisify "^1.0.0"
1720117201

17202-
recoil@^0.0.10:
17203-
version "0.0.10"
17204-
resolved "https://registry.yarnpkg.com/recoil/-/recoil-0.0.10.tgz#679ab22306f559f8a63c46fd5ff5241539f9248f"
17205-
integrity sha512-+9gRqehw3yKETmoZbhSnWu4GO10HDb5xYf1CjLF1oXGK2uT6GX5Lu9mfTXwjxV/jXxEKx8MIRUUbgPxvbJ8SEw==
17202+
recoil@^0.0.13:
17203+
version "0.0.13"
17204+
resolved "https://registry.yarnpkg.com/recoil/-/recoil-0.0.13.tgz#23e6d63135c07d8defbd91aaa35dca94ec5c15a6"
17205+
integrity sha512-2OToaQ8GR//KsdKdaEhMi04QKStLGRpk3qjC58iBpZpUtsByZ4dUy2UJtRcYuhnVlltGZ8HNwcEQRdFOS864SQ==
1720617206

1720717207
1720817208
version "2.2.1"

0 commit comments

Comments
 (0)