halt on netbird err

Author: drewmalin

pkg/cmd/register/register.go

@@ -199,7 +199,9 @@ func runRegister(ctx context.Context, t *terminal.Terminal, s RegisterStore, nam
 
 	t.Vprint(t.Green("  Registration complete."))
 
-	runSetup(node, t, deps)
+	if err := runSetup(node, deps); err != nil {
+		return fmt.Errorf("registration failed: %w", err)
+	}
 
 	if deps.prompter.ConfirmYesNo("Would you like to enable SSH access to this device?") {
 		if err := grantSSHAccess(ctx, t, deps, s, reg, brevUser, osUser); err != nil {
@@ -304,19 +306,17 @@ func netbirdManagementConnected(statusOutput string) bool {
 	return false
 }
 
-func runSetup(node *nodev1.ExternalNode, t *terminal.Terminal, deps registerDeps) {
+func runSetup(node *nodev1.ExternalNode, deps registerDeps) error {
 	ci := node.GetConnectivityInfo()
 	if ci == nil || ci.GetRegistrationCommand() == "" {
-		t.Vprintf("  %s\n", t.Yellow("Warning: Brev tunnel setup failed, please try again."))
-	} else {
-		if err := deps.setupRunner.RunSetup(ci.GetRegistrationCommand()); err != nil {
-			t.Vprintf("  Warning: setup command failed: %v\n", err)
-		} else {
-			// netbird up reconfigures network routes; give them a moment
-			// to settle before making further RPC calls.
-			time.Sleep(2 * time.Second)
-		}
+		return fmt.Errorf("brev tunnel setup failed, please try again")
 	}
+
+	err := deps.setupRunner.RunSetup(ci.GetRegistrationCommand())
+	if err != nil {
+		return fmt.Errorf("setup command failed: %w", err)
+	}
+	return nil
 }
 
 func grantSSHAccess(ctx context.Context, t *terminal.Terminal, deps registerDeps, tokenProvider externalnode.TokenProvider, reg *DeviceRegistration, brevUser *entity.User, osUser *user.User) error {