[BUG] expression_pb2.py is not being generated

[martin-varbanov96]

Description

I had a working buf setup which was working perfectly and after one rebuild I noticed that something was wrong, eventually I found out that the expression_pb2.py is not being generated.

Tried with different proto versions, different PCs.

I was not able to find the expression proto file and where it's generated.

Steps to Reproduce

Expected Behavior

Actual Behavior

Screenshots/Logs

Environment

• Operating System: Linux
• Version: Arch; Bluefin
• Compiler/Toolchain:
• Protobuf Compiler & Version:
• Protoc-gen-validate Version:
• Protovalidate Version: from latest, down to 0.7.1

Possible Solution

My workaround solution was to switch back to v0.7.1 in the buf.yaml file:

buf.build/bufbuild/protovalidate:v0.7.1

Additional Context

[stefanvanburen]

hey @martin-varbanov96, what version of protovalidate-python are you using? As noted in the v0.5.0 release notes, you'll want to update imports from using the generated buf.validate.expression_pb2 to use buf.validate.validate_pb2; you shouldn't need to use generated code from expression.proto now.

[martin-varbanov96]

I was using 0.4.0, I will verify that everything is working with 0.5.0, but in the requirements.in file I did not specify any version... shouldn't it install the latest version? I am using python 3.12.4 . now I have forced it with protovalidate==0.5.0 I guess this should fix the problem

[stefanvanburen]

I'm only somewhat familiar with the requirements.in workflow, but my understanding is that at some point you'd convert that file into a requirements.txt, which may have pinned the previous version.

We do expect some minor breaking changes as we iterate pre-1.0, so it might be better if we pinned the protovalidate module in our README to a particular version known to work with the latest release, but it's just one more place to fall out of date. Once we reach 1.0, we shouldn't have breaking changes like that. Let me know if 0.5.0 doesn't work!

[martin-varbanov96]

I can confirm that 0.5.0 is working perfectly.

python 3.12.4 users using requirements.in files should manually bump their version because the default is 0.4.0 and is not working