Drop custom matcher & config #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We implemented this so that we could avoid a hard dependency on google/re2 due to the lack of wheels being published for Python 3.13. However, [3.13 wheels are now published][1], and our downstream cel-python dep, as of v0.4, is requiring google/re2 as a dependency. It seems like we ought to remove our matches workaround, as well as the configuration for supplying a user-defined matching func, as we generally want all users to have the same behavior for matching. (We can keep in the config value if we really think it's necessary.) [1]: google/re2#516
smaye81
approved these changes
Jul 28, 2025
|
no need to keep it in the config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented this so that we could avoid a hard dependency on google/re2 due to the lack of wheels being published for Python 3.13. However, 3.13 wheels are now published, and our downstream cel-python dep, as of v0.4, is requiring google/re2 as a dependency. It seems like we ought to remove our matches workaround, as well as the configuration for supplying a user-defined matching func, as we generally want all users to have the same behavior for matching. (We can keep in the config value if we really think it's necessary.)