PLAT-9602 make unhandled non null (#813)

* Make unhandled non null

* changelog and upgrading guide

* typo

Author: richardelms

CHANGELOG.md

@@ -8,6 +8,8 @@
 
 - Changed `Configuration.DiscardClasses` and `Configuration.RedactedKeys` to Regex types. [#807](https://github.com/bugsnag/bugsnag-unity/pull/807)
 
+- `Event.Unhandled` is (accessed via OnError and OnSend callbacks) is now non-nullable. [#813](https://github.com/bugsnag/bugsnag-unity/pull/813)
+
 ### Bug Fixes
 
 - Added a null check to the Bugsnag client to prevent crashes when accessing the client before it has been initialised [#788](https://github.com/bugsnag/bugsnag-unity/pull/788)

UPGRADING.md

@@ -7,6 +7,8 @@ Upgrading
 
 If you are using the `DiscardClasses` and `RedactedKeys` sections of the Bugsnag Unity Configuration Window, you can enter Regex patterns as strings and they will be converted into Regex objects when the Bugsnag SDK is started.
 
+`Event.Unhandled` (accessed via OnError and OnSend callbacks) is now non-nullable.
+
 ## 6.x to 7.x
 
 When building using Unity 2019+, the Bugsnag SDK now uses a new method to intercept uncaught C# exceptions. This allows us access to the original exception object, meaning more accurate exception data and full support for inner exceptions.

src/BugsnagUnity/Native/Android/NativeEvent.cs

@@ -28,7 +28,7 @@ public NativeEvent(AndroidJavaObject androidJavaObject) : base (androidJavaObjec
 
         public List<IThread> Threads => GetThreads();
 
-        public bool? Unhandled { get => NativePointer.Call<bool>("isUnhandled"); set => NativePointer.Call("setUnhandled", (bool)value); }
+        public bool Unhandled { get => NativePointer.Call<bool>("isUnhandled"); set => NativePointer.Call("setUnhandled", (bool)value); }
 
         private Severity GetSeverity()
         {

src/BugsnagUnity/Native/Cocoa/NativeEvent.cs

@@ -28,7 +28,13 @@ public class NativeEvent : NativePayloadClassWrapper, IEvent
 
         public string GroupingHash { get => GetNativeString(GROUPING_HASH_KEY); set => SetNativeString(GROUPING_HASH_KEY, value); }
 
-        public bool? Unhandled { get => GetNativeBool(UNHANDLED_KEY); set => SetNativeBool(UNHANDLED_KEY, value); }
+        public bool Unhandled { 
+            get {
+                var nativeBool = GetNativeBool(UNHANDLED_KEY); 
+                return nativeBool.HasValue ? nativeBool.Value : false;
+            }
+            set => SetNativeBool(UNHANDLED_KEY, value); 
+        }
 
         private List<IBreadcrumb> _breadcrumbs = new List<IBreadcrumb>();
 

src/BugsnagUnity/Payload/Event.cs

@@ -61,6 +61,11 @@ internal Event(Dictionary<string, object> serialisedPayload)
             {
                 Add("unhandled", eventObject["unhandled"]);
             }
+            else
+            {
+                Add("unhandled", false);
+            }
+            
             if (eventObject["severity"] != null)
             {
                 Add("severity", eventObject["severity"]);
@@ -190,7 +195,17 @@ internal void AddAndroidProjectPackagesToEvent(string[] packages)
 
         internal LogType? LogType { get; }
 
-        public bool? Unhandled { get => (bool)Get("unhandled"); set => Add("unhandled",value); }
+        public bool Unhandled {     
+        get {
+            var currentValue = Get("unhandled"); 
+            if (currentValue == null) 
+            {
+                return false;
+            }
+            return (bool)currentValue;
+        } 
+        set => Add("unhandled",value); 
+        }
 
         internal bool IsHandled
         {

src/BugsnagUnity/Payload/IEvent.cs

@@ -27,6 +27,6 @@ public interface IEvent: IMetadataEditor, IUserEditor, IFeatureFlagStore
 
         List<IThread> Threads { get; }
 
-        bool? Unhandled { get; set; }
+        bool Unhandled { get; set; }
     }
 }