From 8b771f8745f330ad8517a3b426e4e564b3fe626f Mon Sep 17 00:00:00 2001 From: Simon Cropp Date: Wed, 27 Aug 2025 21:44:51 +1000 Subject: [PATCH] use char based StringBuilder.Append --- .../DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs | 4 ++-- src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs | 4 ++-- src/Cake.Core/Extensions/MethodInfoExtensions.cs | 4 ++-- src/Cake.Core/Extensions/TypeExtensions.cs | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs b/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs index 1950483b76..2129adc0d2 100644 --- a/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs +++ b/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs @@ -259,7 +259,7 @@ private static string GetLoggerValue(MSBuildLogger logger) if (!string.IsNullOrWhiteSpace(logger.Class)) { argumentBuilder.Append(logger.Class); - argumentBuilder.Append(","); + argumentBuilder.Append(','); argumentBuilder.Append(logger.Assembly); } else @@ -269,7 +269,7 @@ private static string GetLoggerValue(MSBuildLogger logger) if (!string.IsNullOrWhiteSpace(logger.Parameters)) { - argumentBuilder.Append(";"); + argumentBuilder.Append(';'); argumentBuilder.Append(logger.Parameters); } diff --git a/src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs b/src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs index 307640cbd4..dae8674d91 100644 --- a/src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs +++ b/src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs @@ -291,14 +291,14 @@ private static string GetLoggerArgument(MSBuildLogger logger) if (!string.IsNullOrWhiteSpace(logger.Class)) { argumentBuilder.Append(logger.Class); - argumentBuilder.Append(","); + argumentBuilder.Append(','); } argumentBuilder.Append(logger.Assembly.Quote()); if (!string.IsNullOrWhiteSpace(logger.Parameters)) { - argumentBuilder.Append(";"); + argumentBuilder.Append(';'); argumentBuilder.Append(logger.Parameters); } return argumentBuilder.ToString(); diff --git a/src/Cake.Core/Extensions/MethodInfoExtensions.cs b/src/Cake.Core/Extensions/MethodInfoExtensions.cs index 7e9a3a2aba..8b347272fc 100644 --- a/src/Cake.Core/Extensions/MethodInfoExtensions.cs +++ b/src/Cake.Core/Extensions/MethodInfoExtensions.cs @@ -31,7 +31,7 @@ public static string GetSignature(this MethodInfo method, var builder = new StringBuilder(); builder.Append(includeMethodNamespace ? method.GetFullName() : method.Name); - builder.Append("("); + builder.Append('('); var parameters = method.GetParameters(); var parameterList = new string[parameters.Length]; for (var i = 0; i < parameterList.Length; i++) @@ -42,7 +42,7 @@ public static string GetSignature(this MethodInfo method, parameterList[i] = signature; } builder.Append(string.Join(", ", parameterList)); - builder.Append(")"); + builder.Append(')'); return builder.ToString(); } diff --git a/src/Cake.Core/Extensions/TypeExtensions.cs b/src/Cake.Core/Extensions/TypeExtensions.cs index fcd619df0c..792e8b3184 100644 --- a/src/Cake.Core/Extensions/TypeExtensions.cs +++ b/src/Cake.Core/Extensions/TypeExtensions.cs @@ -88,12 +88,12 @@ private static string GetGenericTypeName(this Type type, bool includeNamespace) if (includeNamespace) { builder.Append(type.Namespace); - builder.Append("."); + builder.Append('.'); } builder.Append(type.Name.Substring(0, type.Name.IndexOf('`'))); - builder.Append("<"); + builder.Append('<'); builder.Append(GetGenericTypeArguments(type, includeNamespace)); - builder.Append(">"); + builder.Append('>'); return builder.ToString(); }