Ignore files from outside the repository (#977)

Author: pascalberger

src/Cake.Issues.Tap.Tests/LogFileFormat/StylelintLogFileFormatTests.cs

@@ -216,5 +216,18 @@ public void Should_Read_Issue_Correct_When_Absolute_Linux_Path(string repository
                     .OfRule("block-no-empty")
                     .Create());
         }
+
+        [Fact]
+        public void Should_Ignore_Issues_From_Outside_Repository()
+        {
+            // Given
+            var fixture = new TapIssuesProviderFixture<StylelintLogFileFormat>("absolute-windows-path.tap", @"c:\foo");
+
+            // When
+            var issues = fixture.ReadIssues().ToList();
+
+            // Then
+            issues.Count.ShouldBe(0);
+        }
     }
 }

src/Cake.Issues.Tap/BaseTapLogFileFormat.cs

@@ -21,9 +21,15 @@ protected static (bool Valid, string FilePath) ValidateFilePath(string filePath,
         filePath.NotNullOrWhiteSpace();
         repositorySettings.NotNull();
 
-        // Make path relative to repository root.
         if (!new FilePath(filePath).IsRelative)
         {
+            // Ignore files from outside the repository.
+            if (!filePath.IsInRepository(repositorySettings))
+            {
+                return (false, string.Empty);
+            }
+
+            // Make path relative to repository root.
             filePath = filePath.NormalizePath().MakeFilePathRelativeToRepositoryRoot(repositorySettings);
         }
 

src/Cake.Issues.Tap/LogFileFormat/StylelintLogFileFormat.cs

@@ -40,7 +40,7 @@ public override IEnumerable<IIssue> ReadIssues(
                             // Read affected file from the result.
                             if (!TryGetFile(tapResult, repositorySettings, out var fileName))
                             {
-                                this.Log.Information("Skip element since file path could not be parsed");
+                                this.Log.Warning("Skip result {0} since file path could not be parsed", tapResult.TestPointID);
                                 continue;
                             }