Address reviewer feedback: use existing membership pattern

- Remove custom checkIfUserIsTeamAdmin function
- Use existing userId_teamId pattern with prisma.membership.findUnique
- Revert PrismaPlugin and variable name changes
- Maintain same functionality with cleaner implementation

Author: neha

apps/web/modules/bookings/views/bookings-single-view.getServerSideProps.tsx

@@ -11,7 +11,6 @@ import { shouldHideBrandingForEvent } from "@calcom/lib/hideBranding";
 import { parseRecurringEvent } from "@calcom/lib/isRecurringEvent";
 import { markdownToSafeHTML } from "@calcom/lib/markdownToSafeHTML";
 import { maybeGetBookingUidFromSeat } from "@calcom/lib/server/maybeGetBookingUidFromSeat";
-import { isTeamAdmin, isTeamMember } from "@calcom/lib/server/queries/teams";
 import { BookingRepository } from "@calcom/lib/server/repository/booking";
 import prisma from "@calcom/prisma";
 import { customInputSchema } from "@calcom/prisma/zod-utils";
@@ -175,27 +174,29 @@ export async function getServerSideProps(context: GetServerSidePropsContext) {
     );
   };
 
-  const checkIfUserIsTeamMember = async (userId?: number | null) => {
-    if (!userId) return false;
-
-    const teamId = eventType.team?.id;
-    if (teamId) {
-      const teamMemberResult = await isTeamMember(userId, teamId);
-      if (teamMemberResult) return true;
-    }
-
-    const parentTeamId = eventType.parent?.teamId;
-    if (parentTeamId) {
-      const parentTeamMemberResult = await isTeamMember(userId, parentTeamId);
-      if (parentTeamMemberResult) return true;
-    }
+  const isLoggedInUserHost = checkIfUserIsHost(userId);
 
-    return false;
-  };
+  const isLoggedInUserTeamAdmin = !!(
+    userId &&
+    ((eventType.team?.id &&
+      (await prisma.membership.findUnique({
+        where: {
+          userId_teamId: { userId, teamId: eventType.team.id },
+          accepted: true,
+          OR: [{ role: "ADMIN" }, { role: "OWNER" }],
+        },
+      }))) ||
+      (eventType.parent?.teamId &&
+        (await prisma.membership.findUnique({
+          where: {
+            userId_teamId: { userId, teamId: eventType.parent.teamId },
+            accepted: true,
+            OR: [{ role: "ADMIN" }, { role: "OWNER" }],
+          },
+        }))))
+  );
 
-  const isLoggedInUserHost = checkIfUserIsHost(userId);
-  const isLoggedInUserTeamMember = await checkIfUserIsTeamMember(userId);
-  const canViewHiddenData = isLoggedInUserHost || isLoggedInUserTeamMember;
+  const canViewHiddenData = isLoggedInUserHost || isLoggedInUserTeamAdmin;
 
   if (bookingInfo !== null && eventType.seatsPerTimeSlot) {
     await handleSeatsEventTypeOnBooking(eventType, bookingInfo, seatReferenceUid, isLoggedInUserHost);

apps/web/modules/bookings/views/bookings-single-view.tsx

@@ -385,7 +385,7 @@ export default function Success(props: PageProps) {
   const isRescheduled = bookingInfo?.rescheduled;
 
   const canCancelOrReschedule = !eventType?.disableCancelling || !eventType?.disableRescheduling;
-  const _canCancelAndReschedule = !eventType?.disableCancelling && !eventType?.disableRescheduling;
+  const canCancelAndReschedule = !eventType?.disableCancelling && !eventType?.disableRescheduling;
 
   const canCancel = !eventType?.disableCancelling;
   const canReschedule = !eventType?.disableRescheduling;

apps/web/next.config.js

@@ -2,7 +2,7 @@ require("dotenv").config({ path: "../../.env" });
 const englishTranslation = require("./public/static/locales/en/common.json");
 const { withAxiom } = require("next-axiom");
 const { version } = require("./package.json");
-// const { PrismaPlugin } = require("@prisma/nextjs-monorepo-workaround-plugin");
+const { PrismaPlugin } = require("@prisma/nextjs-monorepo-workaround-plugin");
 const {
   i18n: { locales },
 } = require("./next-i18next.config");
@@ -255,7 +255,7 @@ const nextConfig = (phase) => {
           })
         );
 
-        // config.plugins = [...config.plugins, new PrismaPlugin()];
+        config.plugins = [...config.plugins, new PrismaPlugin()];
 
         config.externals.push("formidable");
       }