Skip to content

Commit 2b2e960

Browse files
robertjchenrobertjchen
authored
Merge pull request Expensify#76689 from shubham1206agra/fix-eslint-9
[NoQA] Fixed ESLint
2 parents b4cbab5 + 0dfe55d commit 2b2e960

21 files changed

+28
-24
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
4444
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
4545
"typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
46-
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=145 --cache --cache-location=node_modules/.cache/eslint --concurrency=auto",
46+
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=111 --cache --cache-location=node_modules/.cache/eslint --concurrency=auto",
4747
"lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
4848
"check-lazy-loading": "ts-node scripts/checkLazyLoading.ts",
4949
"lint-watch": "npx eslint-watch --watch --changed",

‎src/components/ImportSpreadsheetConfirmModal.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function ImportSpreadsheetConfirmModal({isVisible, closeImportPageAndModal, onMo
3636
: '';
3737
setTitleText(title);
3838
setPromptText(prompt);
39-
}, [isVisible, spreadsheet?.importFinalModal, translate]);
39+
}, [isVisible, spreadsheet, translate]);
4040

4141
return (
4242
<ConfirmModal

‎src/components/MigratedUserWelcomeModal.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {tryNewDotOnyxSelector} from '@selectors/Onboarding';
33
import React, {useEffect, useMemo, useState} from 'react';
44
import {View} from 'react-native';
55
import useIsPaidPolicyAdmin from '@hooks/useIsPaidPolicyAdmin';
6-
import {useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
6+
// import {useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
77
import useLocalize from '@hooks/useLocalize';
88
import useOnyx from '@hooks/useOnyx';
99
import useResponsiveLayout from '@hooks/useResponsiveLayout';
@@ -38,7 +38,7 @@ function MigratedUserWelcomeModal() {
3838
const [isModalDisabled, setIsModalDisabled] = useState(true);
3939
const route = useRoute<PlatformStackRouteProp<MigratedUserModalNavigatorParamList, typeof SCREENS.MIGRATED_USER_WELCOME_MODAL.ROOT>>();
4040
const shouldOpenSearch = route?.params?.shouldOpenSearch === 'true';
41-
const illustrations = useMemoizedLazyIllustrations(['ExpensifyMobileApp'] as const);
41+
// const illustrations = useMemoizedLazyIllustrations(['MagnifyingGlassReceipt', 'ConciergeBot', 'ChatBubbles'] as const);
4242
const isCurrentUserPolicyAdmin = useIsPaidPolicyAdmin();
4343

4444
const ExpensifyFeatures = useMemo<FeatureListItem[]>(
@@ -56,7 +56,7 @@ function MigratedUserWelcomeModal() {
5656
translationKey: 'migratedUserWelcomeModal.features.chat',
5757
},
5858
],
59-
[illustrations.ExpensifyMobileApp],
59+
[],
6060
);
6161

6262
const [tryNewDot, tryNewDotMetadata] = useOnyx(ONYXKEYS.NVP_TRY_NEW_DOT, {

‎src/components/MoneyRequestConfirmationList.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -977,7 +977,6 @@ function MoneyRequestConfirmationList({
977977
isMerchantEmpty,
978978
shouldDisplayFieldError,
979979
transaction,
980-
iouCategory.length,
981980
policyTags,
982981
isPerDiemRequest,
983982
reportID,
@@ -991,6 +990,8 @@ function MoneyRequestConfirmationList({
991990
isDelegateAccessRestricted,
992991
onSendMoney,
993992
showDelegateNoAccessModal,
993+
iouCategory,
994+
policyCategories,
994995
],
995996
);
996997

‎src/hooks/useSearchSelector.base.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ function useSearchSelectorBase({
288288
maxRecentReportsToShow,
289289
getValidOptionsConfig,
290290
selectedOptions,
291+
includeCurrentUser,
291292
]);
292293

293294
const isOptionSelected = useMemo(() => {

‎src/pages/NewReportWorkspaceSelectionPage.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ function NewReportWorkspaceSelectionPage({route}: NewReportWorkspaceSelectionPag
270270
shouldSyncFocus: true,
271271
}))
272272
.sort((a, b) => localeCompare(a.text, b.text));
273-
}, [policies, isOffline, currentUserPersonalDetails?.login, localeCompare, hasPerDiemTransactions]);
273+
}, [policies, currentUserPersonalDetails?.login, localeCompare, hasPerDiemTransactions]);
274274

275275
const filteredAndSortedUserWorkspaces = useMemo<WorkspaceListItem[]>(
276276
() => usersWorkspaces.filter((policy) => policy.text?.toLowerCase().includes(debouncedSearchTerm?.toLowerCase() ?? '')),

‎src/pages/OnboardingWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ function BaseOnboardingWorkspaceInvite({shouldUseNativeStyles}: BaseOnboardingWo
117117
});
118118
}
119119
return sectionsArr;
120-
}, [areOptionsInitialized, selectedOptionsForDisplay, availableOptions.personalDetails.length, availableOptions.userToInvite, translate]);
120+
}, [areOptionsInitialized, selectedOptionsForDisplay, availableOptions.personalDetails, availableOptions.userToInvite, translate]);
121121

122122
const handleToggleSelection = useCallback(
123123
(option: OptionData) => {

‎src/pages/Search/SearchPage.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,7 @@ function SearchPage({route}: SearchPageProps) {
797797
dismissedRejectUseExplanation,
798798
areAllTransactionsFromSubmitter,
799799
bulkRejectHydrationStatus,
800+
currentUserPersonalDetails?.login,
800801
]);
801802

802803
const handleDeleteExpenses = () => {

‎src/pages/Search/SearchRejectReasonPage.tsx‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React, {useCallback, useEffect} from 'react';
22
import type {FormInputErrors, FormOnyxValues} from '@components/Form/types';
33
import {useSearchContext} from '@components/Search/SearchContext';
4-
import useLocalize from '@hooks/useLocalize';
54
import useOnyx from '@hooks/useOnyx';
65
import {clearErrorFields, clearErrors} from '@libs/actions/FormActions';
76
import {rejectMoneyRequestsOnSearch} from '@libs/actions/Search';
@@ -12,7 +11,6 @@ import ONYXKEYS from '@src/ONYXKEYS';
1211
import INPUT_IDS from '@src/types/form/MoneyRequestRejectReasonForm';
1312

1413
function SearchRejectReasonPage() {
15-
const {translate} = useLocalize();
1614
const context = useSearchContext();
1715
const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true});
1816
const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});
@@ -25,13 +23,10 @@ function SearchRejectReasonPage() {
2523
[context, allPolicies, allReports],
2624
);
2725

28-
const validate = useCallback(
29-
(values: FormOnyxValues<typeof ONYXKEYS.FORMS.MONEY_REQUEST_REJECT_FORM>) => {
30-
const errors: FormInputErrors<typeof ONYXKEYS.FORMS.MONEY_REQUEST_REJECT_FORM> = getFieldRequiredErrors(values, [INPUT_IDS.COMMENT]);
31-
return errors;
32-
},
33-
[translate],
34-
);
26+
const validate = useCallback((values: FormOnyxValues<typeof ONYXKEYS.FORMS.MONEY_REQUEST_REJECT_FORM>) => {
27+
const errors: FormInputErrors<typeof ONYXKEYS.FORMS.MONEY_REQUEST_REJECT_FORM> = getFieldRequiredErrors(values, [INPUT_IDS.COMMENT]);
28+
return errors;
29+
}, []);
3530

3631
useEffect(() => {
3732
clearErrors(ONYXKEYS.FORMS.MONEY_REQUEST_REJECT_FORM);

‎src/pages/home/report/PureReportActionItem.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,6 @@ function PureReportActionItem({
982982
translate,
983983
resolveActionableReportMentionWhisper,
984984
isReportArchived,
985-
formatPhoneNumber,
986985
isOriginalReportArchived,
987986
resolveActionableMentionWhisper,
988987
introSelected,

0 commit comments

Comments
 (0)