fix(eslint): manually fix non-autofixable unicorn/no-array-for-each violations

Author: gelocraft

src/libs/SearchQueryUtils.ts

@@ -346,25 +346,26 @@ function getQueryHashes(query: SearchQueryJSON): {primaryHash: number; recentSea
     // their value when computing the similarSearchHash
     const similarSearchValueBasedFilters = new Set<SearchFilterKey>([CONST.SEARCH.SYNTAX_FILTER_KEYS.ACTION]);
 
-    query.flatFilters
+    const flatFilters = query.flatFilters
         .map((filter) => {
             const filterKey = filter.key;
             const filters = cloneDeep(filter.filters);
             filters.sort((a, b) => customCollator.compare(a.value.toString(), b.value.toString()));
             return {filterString: buildFilterValuesString(filterKey, filters), filterKey};
         })
-        .sort((a, b) => customCollator.compare(a.filterString, b.filterString))
-        .forEach(({filterString, filterKey}) => {
-            if (!similarSearchIgnoredFilters.has(filterKey)) {
-                filterSet.add(filterKey);
-            }
+        .sort((a, b) => customCollator.compare(a.filterString, b.filterString));
 
-            if (similarSearchValueBasedFilters.has(filterKey)) {
-                filterSet.add(filterString.trim());
-            }
+    for (const {filterString, filterKey} of flatFilters) {
+        if (!similarSearchIgnoredFilters.has(filterKey)) {
+            filterSet.add(filterKey);
+        }
 
-            orderedQuery += ` ${filterString}`;
-        });
+        if (similarSearchValueBasedFilters.has(filterKey)) {
+            filterSet.add(filterString.trim());
+        }
+
+        orderedQuery += ` ${filterString}`;
+    }
 
     const similarSearchHash = hashText(Array.from(filterSet).join(''), 2 ** 32);
     const recentSearchHash = hashText(orderedQuery, 2 ** 32);

src/libs/SearchUIUtils.ts

@@ -2582,7 +2582,9 @@ function getColumnsToShow(
     };
 
     if (Array.isArray(data)) {
-        data.forEach(updateColumns);
+        for (const item of data) {
+            updateColumns(item);
+        }
     } else {
         for (const key of Object.keys(data)) {
             if (!isTransactionEntry(key)) {

src/libs/actions/OnyxUpdateManager/utils/index.ts

@@ -99,13 +99,13 @@ function detectGapsAndSplit(lastUpdateIDFromClient: number): DetectGapAndSplitRe
 
         // Add all deferred updates after the gap(s) to "updatesAfterGaps".
         // If "firstUpdateToBeAppliedAfterGap" is set to the last deferred update, the array will be empty.
-        Object.entries(pendingDeferredUpdates).forEach(([lastUpdateID, update]) => {
+        for (const [lastUpdateID, update] of Object.entries(pendingDeferredUpdates)) {
             if (Number(lastUpdateID) < firstUpdateToBeAppliedAfterGap) {
-                return;
+                continue;
             }
 
             updatesAfterGaps[Number(lastUpdateID)] = update;
-        }, {});
+        }
     }
 
     return {applicableUpdates, updatesAfterGaps, latestMissingUpdateID};