Merge pull request Expensify#76358 from gelocraft/fix-no-array-for-each-1764558980

fix(eslint): fix unicorn/no-array-for-each rule violations

Author: roryabraham

src/pages/ReimbursementAccount/NonUSD/utils/getInputKeysForBankInfoStep.ts

@@ -3,10 +3,11 @@ import type {CorpayFields} from '@src/types/onyx';
 
 function getInputKeysForBankInfoStep(corpayFields: CorpayFields | undefined): Record<string, keyof ReimbursementAccountForm> {
     const keys: Record<string, keyof ReimbursementAccountForm> = {};
-    // eslint-disable-next-line unicorn/no-array-for-each
-    corpayFields?.formFields?.forEach((field) => {
-        keys[field.id] = field.id as keyof ReimbursementAccountForm;
-    });
+    if (corpayFields?.formFields) {
+        for (const field of corpayFields.formFields) {
+            keys[field.id] = field.id as keyof ReimbursementAccountForm;
+        }
+    }
     return keys;
 }
 

src/pages/ReimbursementAccount/NonUSD/utils/getSignerDetailsAndSignerFilesForSignerInfo.ts

@@ -1,7 +1,7 @@
 import type {OnyxEntry} from 'react-native-onyx';
 import CONST from '@src/CONST';
 import type {ReimbursementAccountForm} from '@src/types/form';
-import type {BeneficialOwnerDataKey, SignerInfoStepProps} from '@src/types/form/ReimbursementAccountForm';
+import type {BeneficialOwnerDataKey} from '@src/types/form/ReimbursementAccountForm';
 import type {FileObject} from '@src/types/utils/Attachment';
 import SafeString from '@src/utils/SafeString';
 
@@ -26,26 +26,25 @@ function getSignerDetailsAndSignerFilesForSignerInfo(reimbursementAccountDraft:
     const signerDetails: Record<string, string | boolean | FileObject[]> = {};
     const signerFiles: Record<string, string | FileObject | boolean> = {};
 
-    // eslint-disable-next-line unicorn/no-array-for-each
-    signerDetailsFields.forEach((fieldName: keyof SignerInfoStepProps) => {
+    for (const fieldName of signerDetailsFields) {
         if (fieldName === EMAIL) {
             signerDetails[fieldName] = signerEmail;
-            return;
+            continue;
         }
 
         if (!reimbursementAccountDraft?.[fieldName]) {
-            return;
+            continue;
         }
 
         if (fieldName === STREET || fieldName === CITY || fieldName === STATE || fieldName === ZIP_CODE) {
             signerDetails[ADDRESS] = signerDetails[ADDRESS]
                 ? `${SafeString(signerDetails[ADDRESS])}, ${SafeString(reimbursementAccountDraft?.[fieldName])}`
                 : reimbursementAccountDraft?.[fieldName];
-            return;
+            continue;
         }
 
         signerDetails[fieldName] = reimbursementAccountDraft?.[fieldName];
-    });
+    }
 
     if (isUserBeneficialOwner) {
         signerDetails[FULL_NAME] = '';

src/pages/ScheduleCall/ScheduleCallPage.tsx

@@ -94,34 +94,33 @@ function ScheduleCallPage() {
 
         const allTimeSlots = guides.reduce((allSlots, guideAccountID) => {
             const guideSchedule = calendlySchedule?.data?.[guideAccountID];
-            // eslint-disable-next-line unicorn/no-array-for-each
-            guideSchedule?.timeSlots.forEach((timeSlot) => {
-                allSlots.push({
-                    guideAccountID: Number(guideAccountID),
-                    guideEmail: guideSchedule.guideEmail,
-                    startTime: timeSlot.startTime,
-                    scheduleURL: timeSlot.schedulingURL,
-                });
-            });
+            if (guideSchedule) {
+                for (const timeSlot of guideSchedule.timeSlots) {
+                    allSlots.push({
+                        guideAccountID: Number(guideAccountID),
+                        guideEmail: guideSchedule.guideEmail,
+                        startTime: timeSlot.startTime,
+                        scheduleURL: timeSlot.schedulingURL,
+                    });
+                }
+            }
             return allSlots;
         }, [] as TimeSlot[]);
 
         // Group time slots by date to render per day slots on calendar
         const timeSlotMap: Record<string, TimeSlot[]> = {};
-        // eslint-disable-next-line unicorn/no-array-for-each
-        allTimeSlots.forEach((timeSlot) => {
+        for (const timeSlot of allTimeSlots) {
             const timeSlotDate = DateUtils.formatInTimeZoneWithFallback(new Date(timeSlot?.startTime), userTimezone, CONST.DATE.FNS_FORMAT_STRING);
             if (!timeSlotMap[timeSlotDate]) {
                 timeSlotMap[timeSlotDate] = [];
             }
             timeSlotMap[timeSlotDate].push(timeSlot);
-        });
+        }
 
         // Sort time slots within each date array to have in chronological order
-        // eslint-disable-next-line unicorn/no-array-for-each
-        Object.values(timeSlotMap).forEach((slots) => {
+        for (const slots of Object.values(timeSlotMap)) {
             slots.sort((a, b) => new Date(a.startTime).getTime() - new Date(b.startTime).getTime());
-        });
+        }
 
         return timeSlotMap;
     }, [calendlySchedule?.data, userTimezone]);

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx

@@ -55,11 +55,14 @@ function SearchFiltersCategoryPage() {
         const uniqueCategoryNames = new Set<string>();
 
         if (!selectedPoliciesCategories || selectedPoliciesCategories.length === 0) {
-            // eslint-disable-next-line unicorn/no-array-for-each
-            Object.values(allPolicyCategories ?? {}).map((policyCategories) => Object.values(policyCategories ?? {}).forEach((category) => uniqueCategoryNames.add(category.name)));
+            const categories = Object.values(allPolicyCategories ?? {}).flatMap((policyCategories) => Object.values(policyCategories ?? {}));
+            for (const category of categories) {
+                uniqueCategoryNames.add(category.name);
+            }
         } else {
-            // eslint-disable-next-line unicorn/no-array-for-each
-            selectedPoliciesCategories.forEach((category) => uniqueCategoryNames.add(category.name));
+            for (const category of selectedPoliciesCategories) {
+                uniqueCategoryNames.add(category.name);
+            }
         }
         items.push(
             ...Array.from(uniqueCategoryNames)

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTaxRatePage.tsx

@@ -22,16 +22,16 @@ function SearchFiltersTaxRatePage() {
     const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true});
     const allTaxRates = getAllTaxRates(policies);
     const selectedTaxesItems: SearchMultipleSelectionPickerItem[] = [];
-    // eslint-disable-next-line unicorn/no-array-for-each
-    Object.entries(allTaxRates).forEach(([taxRateName, taxRateKeys]) => {
-        // eslint-disable-next-line unicorn/no-array-for-each
-        searchAdvancedFiltersForm?.taxRate?.forEach((taxRateKey) => {
-            if (!taxRateKeys.includes(taxRateKey) || selectedTaxesItems.some((item) => item.name === taxRateName)) {
-                return;
+    for (const [taxRateName, taxRateKeys] of Object.entries(allTaxRates)) {
+        if (searchAdvancedFiltersForm?.taxRate) {
+            for (const taxRateKey of searchAdvancedFiltersForm.taxRate) {
+                if (!taxRateKeys.includes(taxRateKey) || selectedTaxesItems.some((item) => item.name === taxRateName)) {
+                    continue;
+                }
+                selectedTaxesItems.push({name: taxRateName, value: taxRateKeys});
             }
-            selectedTaxesItems.push({name: taxRateName, value: taxRateKeys});
-        });
-    });
+        }
+    }
     const policyIDs = useMemo(() => searchAdvancedFiltersForm?.policyID ?? [], [searchAdvancedFiltersForm?.policyID]);
 
     const selectedPoliciesMap = useMemo(() => {