Add conditional wait for editor action in editor.actions.tests to

stabilize test

Signed-off-by: Aurélien Pupier <[email protected]>

Author: apupier

src/ui-test/tests/actions.requirements.test.ts

@@ -20,6 +20,7 @@ import { ActivityBar, EditorActionDropdown, EditorView, SideBarView, VSBrowser,
 import { CAMEL_ROUTE_YAML_WITH_SPACE, CAMEL_RUN_ACTION_LABEL, CAMEL_RUN_DEBUG_ACTION_LABEL, CAMEL_RUN_DEBUG_FOLDER_ACTION_LABEL, CAMEL_RUN_DEBUG_WORKSPACE_ACTION_LABEL, CAMEL_RUN_FOLDER_ACTION_LABEL, CAMEL_RUN_WORKSPACE_ACTION_LABEL } from "../variables";
 import { expect } from "chai";
 import { notificationCenterContains, waitUntilNotificationShows } from "../utils";
+import { actionAvailable } from './helper/Awaiters';
 
 describe('Check actions requirements to run/debug', function () {
     this.timeout(90000);
@@ -76,6 +77,7 @@ describe('Check actions requirements to run/debug', function () {
     });
 
     async function clickButtonAndVerifyNotification(actionLabel: string) {
+        await actionAvailable(editorView, "Run or Debug...");
         const action = (await editorView.getAction("Run or Debug...")) as EditorActionDropdown;
         const menu = await action.open();
         await menu.select(actionLabel);

src/ui-test/tests/deploy.kubernetes.run.test.ts

@@ -25,6 +25,7 @@ import {
 import { killTerminal, waitUntilTerminalHasText } from '../utils';
 import { CAMEL_ROUTE_YAML_WITH_SPACE } from '../variables';
 import waitUntil from 'async-wait-until';
+import { actionAvailable } from './helper/Awaiters';
 
 /**
  * Note: OC login needs to be done before executing this test for deployment into OpenShift
@@ -52,13 +53,7 @@ describe('Camel standalone file deployment using Camel JBang Kubernetes Run', fu
 
     it('Deploy integration to OpenShift or Kubernetes (Minikube)', async function () {
         await VSBrowser.instance.driver.sleep(500);
-        await waitUntil(async() => {
-            try {
-                return await editorView.getAction('Deploy Integration with Apache Camel Kubernetes Run') !== undefined;
-            } catch {
-                return false;
-            }
-        });
+        await actionAvailable(editorView, 'Deploy Integration with Apache Camel Kubernetes Run');
         const action = (await editorView.getAction('Deploy Integration with Apache Camel Kubernetes Run')) as EditorAction;
         await action.click();
         await waitUntilTerminalHasText(action.getDriver(), ['Hello Camel from'], 10_000, 900_000);

src/ui-test/tests/editor.actions.test.ts

@@ -34,7 +34,7 @@ import {
     isCamelVersionProductized,
 } from '../utils';
 import { CAMEL_RUN_DEBUG_FOLDER_ACTION_LABEL, CAMEL_RUN_DEBUG_WORKSPACE_ACTION_LABEL, CAMEL_RUN_FOLDER_ACTION_LABEL, CAMEL_RUN_WORKSPACE_ACTION_LABEL, TOP_ROUTE_1 } from '../variables';
-import waitUntil from 'async-wait-until';
+import { actionAvailable } from './helper/Awaiters';
 
 describe('Camel file editor test', function () {
 
@@ -138,14 +138,3 @@ describe('Camel file editor test', function () {
         });
     });
 });
-
-async function actionAvailable(editorView: EditorView, actionLabel: string) {
-    await waitUntil(async() => {
-        try {
-            return await editorView.getAction(actionLabel) !== undefined;
-        } catch {
-            return false;
-        }
-    });
-}
-

src/ui-test/tests/helper/Awaiters.ts

@@ -0,0 +1,13 @@
+import waitUntil from 'async-wait-until';
+import { EditorView } from 'vscode-extension-tester';
+
+
+export async function actionAvailable(editorView: EditorView, actionLabel: string) {
+    await waitUntil(async () => {
+        try {
+            return await editorView.getAction(actionLabel) !== undefined;
+        } catch {
+            return false;
+        }
+    });
+}