Skip to content

Commit 9f11017

Browse files
committed
fix: missing decode
1 parent f741ef0 commit 9f11017

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

checkbox-support/checkbox_support/helpers/audio_utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,9 @@ def _load_pw_dump(self):
168168
for _ in range(3):
169169
try:
170170
try:
171-
result = subprocess.check_output(["pw-dump"])
171+
result = subprocess.check_output(["pw-dump"]).decode(
172+
"utf-8"
173+
)
172174
return json.loads(result)
173175
except subprocess.CalledProcessError as e:
174176
raise RuntimeError("Failed to run pw-dump: {}".format(e))

checkbox-support/checkbox_support/helpers/tests/test_audio_utils.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,17 +92,22 @@ def setUp(self):
9292
def test_load_pw_dump_success(self, mock_check_output):
9393
"""Test successful pw-dump load."""
9494
mock_check_output.return_value = b'[{"id": 1, "type": "test"}]'
95+
mock_check_output.return_value.decode = Mock(
96+
return_value='[{"id": 1, "type": "test"}]'
97+
)
9598
result = self.pipewire._load_pw_dump()
9699
self.assertEqual(result, [{"id": 1, "type": "test"}])
97100

98101
@patch("time.sleep", Mock())
99102
@patch("checkbox_support.helpers.audio_utils.subprocess.check_output")
100103
def test_load_pw_dump_retry(self, mock_check_output):
101104
"""Test pw-dump retry on failure."""
105+
success_mock = Mock()
106+
success_mock.decode = Mock(return_value='[{"id": 2, "type": "test3"}]')
102107
mock_check_output.side_effect = [
103108
subprocess.CalledProcessError(1, ""),
104109
json.JSONDecodeError("", "", 0),
105-
b'[{"id": 2, "type": "test3"}]',
110+
success_mock,
106111
]
107112
result = self.pipewire._load_pw_dump()
108113
self.assertEqual(result, [{"id": 2, "type": "test3"}])

0 commit comments

Comments
 (0)