Skip to content

Commit cdb0288

Browse files
authored
fix(ci): make check-removed-urls work with private forks (#437)
* fix(ci): make check-removed-urls work with private forks Fixes #436 * docs: update changelog
1 parent b4eb8de commit cdb0288

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/check-removed-urls.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@ jobs:
1111
- name: Checkout PR branch
1212
uses: actions/checkout@v4
1313
with:
14-
repository: ${{ github.event.pull_request.head.repo.full_name }}
15-
ref: ${{ github.event.pull_request.head.ref }}
14+
# This implicitly gets the PR branch. Making it explicit causes problems
15+
# with private forks, but it is equivalent to the following:
16+
# repository: ${{ github.event.pull_request.head.repo.full_name }}
17+
# ref: ${{ github.event.pull_request.head.ref }}
1618
fetch-depth: 0
1719
path: compare
1820
- name: Checkout base branch
@@ -51,4 +53,4 @@ jobs:
5153
echo "$removed"
5254
echo "Please ensure removed pages are redirected"
5355
exit 1
54-
fi
56+
fi

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* `docs/Makefile` [#373](https://github.com/canonical/sphinx-docs-starter-pack/pull/373)
1414
* `docs/conf.py` [#429](https://github.com/canonical/sphinx-docs-starter-pack/pull/429)
1515
* `docs/.sphinx/update_sp.py` [#425](https://github.com/canonical/sphinx-docs-starter-pack/pull/425)
16+
* `.github/workflows/check-removed-urls.yml` [#437](https://github.com/canonical/sphinx-docs-starter-pack/pull/437)
1617

1718
### Removed
1819

0 commit comments

Comments
 (0)