Design QA Instructions

Summary

• 1. Review PR's changes against Definition of done in Storybook preview links
• 2. Review Percy results
• 3. Comment on PR to request for changes
• 4. Repeat above until no changes are needed
• 5. Approve PR and remove Needs design review label.

1. Review Storybook preview links

Review PR's changes against Definition of done in Storybook preview links. Keep in mind there might be multiple storybooks to review. In general,

• a style package change affects both Web components and React storybooks.
• a new component build in Web components should be reviewed in React wrapper storybook, and not React storybook.
• an experimental component change will require the Feature flag label to generate the Experimental components storybook preview link.
• a RTL (Right to Left language) change will require RTL label to generate the RTL components storybook preview link

2. Review Percy results

• Review Percy snapshots: there should be no unexpected diffs

3. Comment to request changes

• Comment to request changes

Points to keep in mind:

• Be conscientious to the PR's specific goal. If you notice a new issue unrelated (and not triggered by) the current issue, create a new issue.