-
Notifications
You must be signed in to change notification settings - Fork 42
Description
The problem
The layout shell use of margin to move content into place forces the consumer of Carbon to rely on magic numbers and/or known numbers to size the content element.
As a result we see whole page scrolling (scroll bar over the global header), which does not move because of position fixed.
In addition to scrolling there may be other reasons to size elements based on the actual space available which cannot be achieved if the content element does not have a specified size.
As an aside, in Storybook docs it also has the margin bleeding out of the demo.
The story should probably be layout fullscreen too..
The solution
Use CSS Grid with defined areas for header, sidebar and content. No display fixed needed, although personally I choose to fix the body to remove scroll bounce.
NOTE: This probably requrires the introduction of a ui-shell component to contain the shell parts.
Examples
No response
Application/Product
N/A.
Business priority
None
Available extra resources
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Status