Skip to content

[Platforms]: UIShell html structure bugs #827

@alisonjoseph

Description

@alisonjoseph

Summary

There are a couple of issues within SideNav when using type="RAIL_PANEL".


1. Incorrect rendered HTML

The current rendered HTML structure for the SideNav is not correct. Specifically, popovers and tooltips are not being rendered inside their <li> elements.

Expected HTML structure:

<ul>
  <li>...</li>
  <li>...</li>
  <li>...</li>
  ...
</ul>

2. Inline styles in SideNavFlyoutMenu.tsx

Inline styles are currently being used to control visibility in SideNavFlyoutMenu.tsx. These should be removed and replaced with class names and CSS.

Current code:

<div style={{ display: isButtonFocused ? 'none' : 'block' }}>
  {flyoutMenuItems}
</div>

Metadata

Metadata

Assignees

Labels

Sev 2Aspects of design is broken and impedes users in a significant way, but has workaround.area: platformsUsed to filter issues in the Carbon for Platforms effort.role: dev 🤖type: bug 🐛Something isn't working

Type

Projects

Status

🏗 In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions