Skip to content

Conversation

RichKummer
Copy link
Contributor

@RichKummer RichKummer commented Oct 7, 2025

Closes #8194

This PR covers the basics of EmptyState code connect, but does not account for the different EmptyState components in code such as EmptyErrorState, UnauthorizedEmptyState, etc. Those will be handled in a separate PR in issue #8416

Code Figma Notes
size (lg, sm) Size (Large, Small) selection  
illustrationPosition (top, right, bottom, left) Illustration position (Bottom, Right, Left, Top) selection  
action object Button boolean
link any Link boolean
title Title text string  
subtitle Subtitle text string  
  (Nested instances of illustrations) Figma treats this as a selection for illustration, but the code treats these as separate components. Likely needs to be resolved in a separate PR

What did you change?

How did you test and verify your work?

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit a4c8d21
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/68f62cd7677a060008a13e8b
😎 Deploy Preview https://deploy-preview-8402--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit a4c8d21
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/68f62cd7b78ce900088ebd2b
😎 Deploy Preview https://deploy-preview-8402--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@RichKummer RichKummer changed the title add first selections feat(EmptyState): Code connect Oct 7, 2025
@RichKummer RichKummer marked this pull request as ready for review October 8, 2025 16:47
@RichKummer RichKummer requested a review from a team as a code owner October 8, 2025 16:47
@RichKummer RichKummer requested review from amal-k-joy and jlongshore and removed request for a team October 8, 2025 16:47
jlongshore
jlongshore previously approved these changes Oct 16, 2025
Copy link
Contributor

@jlongshore jlongshore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publishes to Figma, appears to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figma Code Connect - React (EmptyState)

2 participants