Skip to content

Commit db43bb1

Browse files
authored
Replace FIXME with TODO in toolchain code (#4506)
1 parent 5759ad8 commit db43bb1

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

toolchain/check/testdata/class/fail_abstract.carbon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class Derived {
126126
}
127127

128128
fn Return(a: Abstract) -> Abstract {
129-
// FIXME: Seems like this would be better off failing with "function returns abstract type" here instead of this \/
129+
// TODO: Seems like this would be better off failing with "function returns abstract type" here instead of this \/
130130
// CHECK:STDERR: fail_return_abstract.carbon:[[@LINE+7]]:3: error: initialization of abstract type `Abstract` [AbstractTypeInInit]
131131
// CHECK:STDERR: return a;
132132
// CHECK:STDERR: ^~~~~~~~~

toolchain/docs/check.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ process entries from the node stack until it finds that solo parse node from
415415
`ReturnStatementStart` that indicates it is done.
416416
417417
Another pattern that arises is state is set up by an introducer node, updated by
418-
its siblings, and then consumed by the bracketing parent node. FIXME: example
418+
its siblings, and then consumed by the bracketing parent node. TODO: example
419419
420420
### Node stack
421421

toolchain/docs/idioms.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ A fairly complete list of `ValueStore` uses should be available on
171171

172172
## Template metaprogramming
173173

174-
FIXME: show example patterns
174+
TODO: show example patterns
175175

176176
- TypedInstArgsInfo from toolchain/sem_ir/inst.h
177177
- templated using

toolchain/docs/parse.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ declaration or statement.
596596

597597
### Something required in context
598598

599-
FIXME
599+
TODO
600600

601601
Example: name after introducer
602602
[parse/handle_decl_name_and_params.cpp](/toolchain/parse/handle_decl_name_and_params.cpp)
@@ -796,7 +796,7 @@ deal with the `as` that follows when the type expression is present.
796796

797797
### Operators
798798

799-
FIXME
799+
TODO
800800

801801
An independent description of our approach:
802802
["Better operator precedence" on scattered-thoughts.net](https://www.scattered-thoughts.net/writing/better-operator-precedence/)

toolchain/lower/file_context.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ auto FileContext::BuildDICompileUnit(llvm::StringRef module_name,
100100
llvm_module.addModuleFlag(llvm::Module::Max, "Dwarf Version", 5);
101101
llvm_module.addModuleFlag(llvm::Module::Warning, "Debug Info Version",
102102
llvm::DEBUG_METADATA_VERSION);
103-
// FIXME: Include directory path in the compile_unit_file.
103+
// TODO: Include directory path in the compile_unit_file.
104104
llvm::DIFile* compile_unit_file = di_builder.createFile(module_name, "");
105-
// FIXME: Introduce a new language code for Carbon. C works well for now since
105+
// TODO: Introduce a new language code for Carbon. C works well for now since
106106
// it's something debuggers will already know/have support for at least.
107107
// Probably have to bump to C++ at some point for virtual functions,
108108
// templates, etc.
@@ -447,7 +447,7 @@ auto FileContext::BuildDISubprogram(const SemIR::Function& function,
447447
CARBON_CHECK(name, "Unexpected special name for function: {0}",
448448
function.name_id);
449449
auto loc = GetLocForDI(function.definition_id);
450-
// FIXME: Add more details here, including real subroutine type (once type
450+
// TODO: Add more details here, including real subroutine type (once type
451451
// information is built), etc.
452452
return di_builder_.createFunction(
453453
di_compile_unit_, *name, llvm_function->getName(),

0 commit comments

Comments
 (0)