From 6e03bc8ae2e4d973397db0e77c9764e3bcbe9f25 Mon Sep 17 00:00:00 2001
From: Vince Broz <vince@broz.cc>
Date: Thu, 11 Sep 2025 14:19:00 -0400
Subject: [PATCH 1/2] Handle bad gemdir from gemspec object

---
 lib/solargraph/gem_pins.rb | 1 +
 lib/solargraph/yardoc.rb   | 9 +++++++++
 spec/gem_pins_spec.rb      | 5 +++++
 3 files changed, 15 insertions(+)

diff --git a/lib/solargraph/gem_pins.rb b/lib/solargraph/gem_pins.rb
index a193a8a39..ba362c351 100644
--- a/lib/solargraph/gem_pins.rb
+++ b/lib/solargraph/gem_pins.rb
@@ -46,6 +46,7 @@ def self.combine_method_pins(*pins)
     # @return [Array<Pin::Base>]
     def self.build_yard_pins(yard_plugins, gemspec)
       Yardoc.cache(yard_plugins, gemspec) unless Yardoc.cached?(gemspec)
+      return [] unless Yardoc.cached?(gemspec)
       yardoc = Yardoc.load!(gemspec)
       YardMap::Mapper.new(yardoc, gemspec).map
     end
diff --git a/lib/solargraph/yardoc.rb b/lib/solargraph/yardoc.rb
index 625e41ce4..43424d99a 100644
--- a/lib/solargraph/yardoc.rb
+++ b/lib/solargraph/yardoc.rb
@@ -18,6 +18,15 @@ def cache(yard_plugins, gemspec)
       path = PinCache.yardoc_path gemspec
       return path if cached?(gemspec)
 
+      unless Dir.exist? gemspec.gem_dir
+        # Can happen in at least some (old?) RubyGems versions when we
+        # have a gemspec describing a standard library like bundler.
+        #
+        # https://github.com/apiology/solargraph/actions/runs/17650140201/job/50158676842?pr=10
+        Solargraph.logger.info { "Bad info from gemspec - #{gemspec.gem_dir} does not exist" }
+        return path
+      end
+
       Solargraph.logger.info "Caching yardoc for #{gemspec.name} #{gemspec.version}"
       cmd = "yardoc --db #{path} --no-output --plugin solargraph"
       yard_plugins.each { |plugin| cmd << " --plugin #{plugin}" }
diff --git a/spec/gem_pins_spec.rb b/spec/gem_pins_spec.rb
index d630784cf..c3c18109d 100644
--- a/spec/gem_pins_spec.rb
+++ b/spec/gem_pins_spec.rb
@@ -11,4 +11,9 @@
     expect(core_root.return_type.to_s).to eq('Pathname, nil')
     expect(core_root.location.filename).to end_with('environment_loader.rb')
   end
+
+  it "does not error out when handed incorrect gemspec" do
+    gemspec = instance_double(Gem::Specification, name: 'foo', version: '1.0', gem_dir: "/not-there")
+    expect { Solargraph::GemPins.build_yard_pins([], gemspec) }.not_to raise_error
+  end
 end

From 62d7d0833bd366a7b98690e157a1dd79be2db658 Mon Sep 17 00:00:00 2001
From: Vince Broz <vince@broz.cc>
Date: Thu, 11 Sep 2025 14:29:03 -0400
Subject: [PATCH 2/2] Linting fix

---
 spec/gem_pins_spec.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/spec/gem_pins_spec.rb b/spec/gem_pins_spec.rb
index c3c18109d..8e3962341 100644
--- a/spec/gem_pins_spec.rb
+++ b/spec/gem_pins_spec.rb
@@ -12,8 +12,8 @@
     expect(core_root.location.filename).to end_with('environment_loader.rb')
   end
 
-  it "does not error out when handed incorrect gemspec" do
-    gemspec = instance_double(Gem::Specification, name: 'foo', version: '1.0', gem_dir: "/not-there")
+  it 'does not error out when handed incorrect gemspec' do
+    gemspec = instance_double(Gem::Specification, name: 'foo', version: '1.0', gem_dir: '/not-there')
     expect { Solargraph::GemPins.build_yard_pins([], gemspec) }.not_to raise_error
   end
 end