ModularChainInfo: branch for merge #1654

editaahn · 2025-11-11T09:13:28Z

Linear KEPLR-1305

배경

multichain ecosystem에 맞춘 코드 베이스로 개선

Cosmos, EVM 체인 정보를 담는 ChainInfo 타입과 Starknet, Bitcoin 정보를 담는 ModularChainInfo 타입이 혼용되고 있어 코드 복잡성 상승 -> ModularChainInfo 타입 하나만을 주사용할 수 있도록 한다.

진행 상태

Extension 스모킹 테스트 마침
develop 브랜치 충돌 해결 완료 (2025/11/27 기준) - Topup, Supernova release 후 본 브랜치에서 병합 충돌 해결
peer review 완료

예정 timeline

Extension QA
Mobile QA

변경 사항 요약

ModularChainInfo 타입 확장 code

CosmosInfoModule 타입에 evm 추가 (as-is: EVM 체인도 cosmos 타입을 사용하고 있었음)

EVM only chain을 위한 Union 타입, EVM compatible Cosmos를 위한 Union 타입 신규 추가함

export type ModularChainInfo = ModularChainInfoBase &
  (
    | {
        readonly cosmos: ChainInfo;
      }
    | {
        readonly starknet: StarknetChainInfo;
      }
    | {
        readonly bitcoin: BitcoinChainInfo;
        readonly linkedChainKey: string;
      }
    // EVM only chain
    | {
        readonly evm: EVMNativeChainInfo;
      }
    // EVM compatible Cosmos chain
    | {
        readonly cosmos: ChainInfo;
        readonly evm: EVMNativeChainInfo;
      }
  );

isNative: 기존 ChainInfo 타입에서는 native 체인 여부를 알기 위해 embedded.embedded 또는 beta 필드 사용 -> ModularChainInfo에서는 isNative라는 이름으로 통합

  export interface ModularChainInfoBase {
    readonly chainId: string;
    readonly chainName: string;
    readonly chainSymbolImageUrl?: string;
    readonly isTestnet?: boolean;
    readonly isNative?: boolean; // 신규 추가
  }

logic 상 분리: EVM <> Cosmos

코드 예시

// 변경 전 - cosmos 객체에 evm도 포함된 구조
  if ("cosmos" in modularChainInfo) { ... } 

// 변경 후 - evm 객체를 동일 차원으로 분리
  if ("evm" in modularChainInfo) { 
    ... 
  } else if ("cosmos" in modularChainInfo) { 
  ... 
  }

ModularChainInfoImpl 확장 및 메서드 최적화 code packages/stores/src/chain/base.ts
- ChainInfoImpl에만 있던 메서드 마이그레이션 + 코드 개선 (hasFeature, findCurrency, forceFindCurrency, addUnknownDenoms 등등)
- 메서드 추가 및 조정 (matchModules, getCurrencies, getCurrenciesByModule, stakeCurrency 등등)
ChainInfo -> ModularChainInfo 사용부 legacy 전면 교체
- type 교체
  - ChainInfo, IChainInfoImpl -> ModularChainInfo, ModularChainInfoImpl
- ChainStore 메서드 교체
  - ChainStore.getChain -> getModularChain or getModularChainInfoImpl
  - ChainStore.hasChain -> hasModularChain or matchModules
- ChainStore accessor 교체
  - ChainStore.chainInfos -> modularChainInfos
  - chainStore.chainInfosInUI -> modularChainInfosInUI
분기가 필요한 경우는 “cosmos”, “evm”, “bitcoin” 등의 객체 존재 여부로 확인하시거나,
getModularChainInfoImpl(chainId).matchModule(“cosmos”)
getModularChainInfoImpl(chainId).matchModules({ or: [“cosmos”, “evm”] }) 등을 사용해주세요.

기타 참고사항

experimentalSuggestChain 같은 method는 기존 legacy ChainInfo를 사용해야함
- ModularChainInfo -> ChainInfo로 convert해서 직접 호환하도록 packages/common 추가 (convertModularChainInfoToChainInfo) code
- 관련 코드에서 ChainInfo 타입을 그대로 사용하는 곳들도 존재함 (e.g. useGetAllNonNativeChain)
History: 아래 PR들이 합쳐짐
ModularChainInfo 타입 수정 / stores, background 내부의 modularChainInfos 데이터 가공 시 분기 #1590
[Ext] cosmos <> evm 모듈 상세 로직 분기: Balance 조회 및 Custom token 관리 #1597
[Ext] cosmos <> evm 모듈 상세 로직 분기: 세부 기능 별 분기 #1606
add methods to ModularChainInfoImpl and refactor #1607
replace legacy ChainInfo #1619
머지 충돌 해결 / 후속 빌드 애러 해결
- Topup: 3cc1937
- Supernova: 9414a3d, 4607193

…sic-updates ModularChainInfo 타입 수정 / stores, background 내부의 modularChainInfos 데이터 가공 시 분기

…ncies`

…modular-merge

editaahn · 2025-11-27T05:42:14Z

packages/stores/src/chain/base.ts

breaking changes on ModularChainInfoImpl

kws1207 · 2025-11-27T13:54:09Z

packages/stores/src/chain/base.ts

  }

  get modularChainInfos(): ModularChainInfo[] {
+    console.log(


혹시 여기 포함 이 파일의 console.log들은 의도적으로 남겨두신 걸까요?

테스트용으로 남겨뒀는데요! QA 후 머지되기 전 지우겠습니다

콘솔로그 제거했습니다.

packages/background/src/chains/service.ts

apps/extension/src/pages/setting/token/add/index.tsx

apps/extension/src/stores/ui-config/manage-view-asset-token.ts

packages/stores/src/query/balances.ts

kws1207 · 2025-11-27T14:34:24Z

apps/extension/src/pages/main/index.tsx

+            const denomHelper = new DenomHelper(currency.coinMinimalDenom);
+            if (denomHelper.type === "erc20") {
+              // XXX: 얘는 구조상 waitFreshResponse()가 안되서 일단 쿼리가 끝인지 아닌지는 무시한다.
+              queryBalance.fetch();


이거 기존 코드 같은데 로직이 잘 이해가 안되네요, 왜 동일한 query를 for문을 돌면서 반복 fetch 하는건지 궁금합니다!

그러게요. queryBalance.getBalance(currency).fetch() 요렇게 가는게 의도가 아니었을지..? 정환님 확인 한번 해주셔요 @Thunnini

apps/extension/src/pages/earn/confirm-usdn-estimation/index.tsx

packages/stores/src/account/base.ts

packages/background/src/chains/service.ts

apps/extension/src/pages/main/token-detail/receive-modal/index.tsx

editaahn

@kws1207 주신 코멘트들 확인했어요. 감사합니다! 반영 후에 핑 한번 더 드릴게요 👍

editaahn · 2025-11-28T04:12:07Z

packages/stores/src/chain/base.ts

  }

  get modularChainInfos(): ModularChainInfo[] {
+    console.log(


테스트용으로 남겨뒀는데요! QA 후 머지되기 전 지우겠습니다

apps/extension/src/pages/setting/token/add/index.tsx

apps/extension/src/stores/ui-config/manage-view-asset-token.ts

packages/background/src/chains/service.ts

packages/stores/src/account/base.ts

packages/stores/src/query/balances.ts

editaahn · 2025-11-28T06:09:18Z

apps/extension/src/pages/main/index.tsx

+            const denomHelper = new DenomHelper(currency.coinMinimalDenom);
+            if (denomHelper.type === "erc20") {
+              // XXX: 얘는 구조상 waitFreshResponse()가 안되서 일단 쿼리가 끝인지 아닌지는 무시한다.
+              queryBalance.fetch();


그러게요. queryBalance.getBalance(currency).fetch() 요렇게 가는게 의도가 아니었을지..? 정환님 확인 한번 해주셔요 @Thunnini

editaahn · 2025-12-01T06:09:42Z

@kws1207 Sam님 코멘트 반영됐습니다.

blacktoast

제가 잘못 한 걸수도 있는데

계정 처음 생성 하고 체인 선택할때 evm계열 체인이 선택이 안되는것 같아요
현재 배포 버전은 evm 계열이 선택이 되어 있긴합니다

apps/extension/src/hooks/use-staked-total-price.ts

apps/extension/src/hooks/use-topup.ts

apps/extension/src/pages/main/spendable.tsx

packages/stores-core/src/core/tokens.ts

…modular-merge

editaahn

@blacktoast @piatoss3612
두 분이 주신 피드백 반영했습니다. 감사합니다~! 078d35c
레또님이 발견해주신 누락된 분기도 처리했습니다. 16d6d9f

apps/extension/src/pages/main/spendable.tsx

packages/stores-core/src/core/tokens.ts

…modular-merge

editaahn and others added 30 commits September 19, 2025 12:51

branch evm native chain info from ModularChainInfo

1ebf537

add Union for EthermintLike / rename evmNative to evm

d6b381b

Merge pull request #1590 from chainapsis/editaahn/refactor-modular/ba…

bad841d

…sic-updates ModularChainInfo 타입 수정 / stores, background 내부의 modularChainInfos 데이터 가공 시 분기

add condition for evm chains when displaying swap tab

45f2b3e

add conditions for evm custom tokens

0d54c9e

add conditions for listing evm balances

b11caea

fix to display erc token currencies

51d09de

use modularChainInfoImpl.getCurrencies("evm") in updateBalances

01382f8

normalize currency denoms while fetching balance

d1558b9

merge repo's currencies to modualr chain infos

c42d957

hide assets without balance

097d9f2

fix: show custom token balances

3f19011

branch evm<>cosmos in TokenDetail

2cb8c63

branch evm<>cosmos in CopyAddress

b3e40e2

modularChainInfos for suggest chains

4267643

update refresh button logic for evm chains

78f1dd8

update QR code condition in ReceiveModal

3f63317

update KeyRing's coinType branching

5cf83c7

update detail functionalities

73df350

add methods to ModularChainInfoImpl for replacing ChainInfoImpl

fea02fe

update forceFindCurrency, findCurrency not to require module arg

d650229

provide hasFeature

6a3fa58

rename getCurrencies to getCurrenciesByModule / add new `getCurre…

0c3bc4e

…ncies`

add feeCurrencies to EVMNativeChainInfo

457e14f

use forceFindCurrency

1529d2e

provide findCurrencyAsync and replace

d16ae81

provide stakeCurrency, feeCurrencies from ModularChainInfoImpl

58ad1a2

replace chainStore.getChain with chainStore.getModularChain

bb5db35

replace all chainStore.hasChain to hasModularChain

57fe152

update balance logics to use modularChainInfo

825cb87

editaahn added 3 commits November 26, 2025 17:51

replace rest chainStore.chainInfosInUI with modularChainInfosInUI

27b0d8b

Merge remote-tracking branch 'origin/develop' into editaahn/refactor-…

9414a3d

…modular-merge

adjust for ModularChainInfo conversion after Supernova update

4607193

vercel bot deployed to Preview November 27, 2025 05:38 View deployment

deprecate old chain info accessors and methods in ChainStore

186cded

vercel bot deployed to Preview November 27, 2025 11:24 View deployment

editaahn marked this pull request as ready for review November 27, 2025 11:38

editaahn requested a review from a team as a code owner November 27, 2025 11:38

editaahn commented Nov 27, 2025

View reviewed changes

packages/stores/src/chain/base.ts

Copy link

Collaborator Author

editaahn Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking changes on ModularChainInfoImpl

kws1207 reviewed Nov 27, 2025

View reviewed changes

editaahn commented Nov 28, 2025

View reviewed changes

code improvement

741baef

vercel bot deployed to Preview December 1, 2025 05:54 View deployment

blacktoast previously approved these changes Dec 2, 2025

View reviewed changes

apps/extension/src/hooks/use-staked-total-price.ts Show resolved Hide resolved

piatoss3612 reviewed Dec 3, 2025

View reviewed changes

apps/extension/src/hooks/use-topup.ts Outdated Show resolved Hide resolved

apps/extension/src/pages/main/spendable.tsx Outdated Show resolved Hide resolved

packages/stores-core/src/core/tokens.ts Show resolved Hide resolved

editaahn added 3 commits December 3, 2025 17:32

code improvement

078d35c

key finalization and chain enabling logic to include EVM chains

16d6d9f

Merge remote-tracking branch 'origin/develop' into editaahn/refactor-…

f9bdcb3

…modular-merge

editaahn dismissed blacktoast’s stale review via f9bdcb3 December 3, 2025 13:00

vercel bot deployed to Preview December 3, 2025 13:00 View deployment

editaahn commented Dec 3, 2025

View reviewed changes

apps/extension/src/pages/main/spendable.tsx Outdated Show resolved Hide resolved

packages/stores-core/src/core/tokens.ts Show resolved Hide resolved

Merge remote-tracking branch 'origin/develop' into editaahn/refactor-…

12029f3

…modular-merge

vercel bot deployed to Preview December 4, 2025 05:47 View deployment

remove console.log

d369ff5

vercel bot deployed to Preview December 4, 2025 05:49 View deployment

Merge remote-tracking branch 'origin/develop' into editaahn/refactor-…

bbe32fd

…modular-merge

vercel bot deployed to Preview December 5, 2025 09:23 View deployment

v0.12.300-rc.0

8381489

vercel bot deployed to Preview December 5, 2025 09:36 View deployment

ModularChainInfo: branch for merge #1654

Are you sure you want to change the base?

ModularChainInfo: branch for merge #1654

Uh oh!

Conversation

editaahn commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

배경

진행 상태

예정 timeline

변경 사항 요약

기타 참고사항

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

editaahn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

editaahn commented Dec 1, 2025

Uh oh!

blacktoast left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

editaahn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

editaahn commented Nov 11, 2025 •

edited

Loading