Skip to content

Commit d5819c9

Browse files
jjmerchantejjmerchante
committed
Remove mix_stderr parameter from CliRunner instances
This commit removes the mix_stderr=False parameter from all instances of CliRunner in the test suite. The mix_stderr was required to separate the standard error from the standard output in the test results. However, in the latest version of the package this argument was removed and now always collect stderr output and never raise an exception
1 parent f88292f commit d5819c9

13 files changed

+25
-25
lines changed

‎tests/cli/test_cmd_add.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def test_error(self, mock_client):
225225
client = MockClient(responses)
226226
mock_client.return_value = client
227227

228-
runner = click.testing.CliRunner(mix_stderr=False)
228+
runner = click.testing.CliRunner()
229229

230230
params = [
231231
'--source', 'scm',

‎tests/cli/test_cmd_config.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def test_default_filename(self, mock_basepath):
104104
def test_config_is_not_overwritten(self):
105105
"""Check whether an existing config file is not replaced"""
106106

107-
runner = click.testing.CliRunner(mix_stderr=False)
107+
runner = click.testing.CliRunner()
108108

109109
with runner.isolated_filesystem() as fs:
110110
shutil.copy(MOCK_CONFIG_FILEPATH, fs)
@@ -132,7 +132,7 @@ def test_config_is_not_overwritten(self):
132132
def test_overwrite_config(self):
133133
"""Check whether an existing config file is overwritten"""
134134

135-
runner = click.testing.CliRunner(mix_stderr=False)
135+
runner = click.testing.CliRunner()
136136

137137
with runner.isolated_filesystem() as fs:
138138
shutil.copy(MOCK_CONFIG_FILEPATH, fs)
@@ -240,7 +240,7 @@ def test_default_filename(self, mock_basepath):
240240
def test_not_available_keys(self):
241241
"""Check if it raises an error when the key is not available"""
242242

243-
runner = click.testing.CliRunner(mix_stderr=False)
243+
runner = click.testing.CliRunner()
244244

245245
with runner.isolated_filesystem() as fs:
246246
shutil.copy(MOCK_CONFIG_FILEPATH, fs)
@@ -260,7 +260,7 @@ def test_not_available_keys(self):
260260
def test_invalid_keys(self):
261261
"""Check if it raises an error when the key is invalid"""
262262

263-
runner = click.testing.CliRunner(mix_stderr=False)
263+
runner = click.testing.CliRunner()
264264

265265
# Test keys that do not follow '<section>.<option>' schema
266266
with runner.isolated_filesystem() as fs:
@@ -321,7 +321,7 @@ def test_invalid_keys(self):
321321
def test_invalid_config_files(self):
322322
"""Check whether it raises and error reading invalid configuration files"""
323323

324-
runner = click.testing.CliRunner(mix_stderr=False)
324+
runner = click.testing.CliRunner()
325325

326326
# Test keys that do not follow '<section>.<option>' schema
327327
with runner.isolated_filesystem() as fs:
@@ -405,7 +405,7 @@ def test_default_filename(self, mock_basepath):
405405
def test_not_available_keys(self):
406406
"""Check if it raises an error when the key is not available"""
407407

408-
runner = click.testing.CliRunner(mix_stderr=False)
408+
runner = click.testing.CliRunner()
409409

410410
with runner.isolated_filesystem() as fs:
411411
shutil.copy(MOCK_CONFIG_FILEPATH, fs)
@@ -424,7 +424,7 @@ def test_not_available_keys(self):
424424
def test_invalid_keys(self):
425425
"""Check if it raises an error when the key is invalid"""
426426

427-
runner = click.testing.CliRunner(mix_stderr=False)
427+
runner = click.testing.CliRunner()
428428

429429
# Test keys that do not follow '<section>.<option>' schema
430430
with runner.isolated_filesystem() as fs:
@@ -480,7 +480,7 @@ def test_invalid_keys(self):
480480
def test_invalid_config_files(self):
481481
"""Check whether it raises and error reading invalid configuration files"""
482482

483-
runner = click.testing.CliRunner(mix_stderr=False)
483+
runner = click.testing.CliRunner()
484484

485485
with runner.isolated_filesystem() as fs:
486486
filepath = os.path.join(fs, 'unknown_file.cfg')

‎tests/cli/test_cmd_countries.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def test_countries_code(self, mock_client):
193193
def test_countries_invalid_code(self):
194194
"""Check if it fails when code is invalid"""
195195

196-
runner = click.testing.CliRunner(mix_stderr=False)
196+
runner = click.testing.CliRunner()
197197

198198
params = ['--code', 'E']
199199
result = runner.invoke(countries, params)
@@ -263,7 +263,7 @@ def test_countries_term(self, mock_client):
263263
def test_countries_invalid_term(self):
264264
"""Check if it fails when term is invalid"""
265265

266-
runner = click.testing.CliRunner(mix_stderr=False)
266+
runner = click.testing.CliRunner()
267267

268268
params = ['--term', 'E']
269269
result = runner.invoke(countries, params)
@@ -334,7 +334,7 @@ def test_error(self, mock_client):
334334
client = MockClient(responses)
335335
mock_client.return_value = client
336336

337-
runner = click.testing.CliRunner(mix_stderr=False)
337+
runner = click.testing.CliRunner()
338338

339339
result = runner.invoke(countries)
340340

‎tests/cli/test_cmd_enroll.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def test_invalid_dates_error(self, mock_client):
180180
client = MockClient([])
181181
mock_client.return_value = client
182182

183-
runner = click.testing.CliRunner(mix_stderr=False)
183+
runner = click.testing.CliRunner()
184184

185185
params = [
186186
'322397ed782a798ffd9d0bc7e293df4292fe075d',
@@ -225,7 +225,7 @@ def test_error(self, mock_client):
225225
client = MockClient(responses)
226226
mock_client.return_value = client
227227

228-
runner = click.testing.CliRunner(mix_stderr=False)
228+
runner = click.testing.CliRunner()
229229

230230
params = [
231231
'322397ed782a798ffd9d0bc7e293df4292fe075d',

‎tests/cli/test_cmd_lock.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def test_error(self):
116116
]
117117
mock_client = MockClient(responses)
118118

119-
runner = click.testing.CliRunner(mix_stderr=False)
119+
runner = click.testing.CliRunner()
120120

121121
params = [
122122
'FFFFFFFFFFFFFFF'
@@ -174,7 +174,7 @@ def test_error(self):
174174
]
175175
mock_client = MockClient(responses)
176176

177-
runner = click.testing.CliRunner(mix_stderr=False)
177+
runner = click.testing.CliRunner()
178178

179179
params = [
180180
'FFFFFFFFFFFFFFF'

‎tests/cli/test_cmd_merge.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def test_error(self, mock_client):
113113
client = MockClient(responses)
114114
mock_client.return_value = client
115115

116-
runner = click.testing.CliRunner(mix_stderr=False)
116+
runner = click.testing.CliRunner()
117117

118118
params = [
119119
'322397ed782a798ffd9d0bc7e293df4292fe075d',

‎tests/cli/test_cmd_mv.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def test_error(self, mock_client):
147147
client = MockClient(responses)
148148
mock_client.return_value = client
149149

150-
runner = click.testing.CliRunner(mix_stderr=False)
150+
runner = click.testing.CliRunner()
151151

152152
params = [
153153
'322397ed782a798ffd9d0bc7e293df4292fe075d',

‎tests/cli/test_cmd_profile.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ def test_error(self, mock_client):
310310
client = MockClient(responses)
311311
mock_client.return_value = client
312312

313-
runner = click.testing.CliRunner(mix_stderr=False)
313+
runner = click.testing.CliRunner()
314314

315315
params = [
316316
'FFFFFFFFFFFFFFF'

‎tests/cli/test_cmd_rm.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def test_error(self, mock_client):
146146
client = MockClient(responses)
147147
mock_client.return_value = client
148148

149-
runner = click.testing.CliRunner(mix_stderr=False)
149+
runner = click.testing.CliRunner()
150150

151151
params = ['FFFFFFFFFFFFFFF']
152152
result = runner.invoke(rm, params, obj=mock_client)

‎tests/cli/test_cmd_show.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ def test_error(self, mock_client):
431431
client = MockClient(responses)
432432
mock_client.return_value = client
433433

434-
runner = click.testing.CliRunner(mix_stderr=False)
434+
runner = click.testing.CliRunner()
435435

436436
result = runner.invoke(show)
437437

0 commit comments

Comments
 (0)