Skip to content

Conversation

@sepans
Copy link

@sepans sepans commented Jan 11, 2016

basic medium.com support.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sepans thanks for the PR!

Any reason we need this line?
Would it be possible to be consistent with something like https://github.com/christianvuerings/jquery-lifestream/blob/master/src/services/blogger.js

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @christianvuerings,

Thats what I tried first. item.description returned by medium feed is itself a html snippet so it has to be something like: html: $.tmpl( template.posted, item ) + item.descirtion with item.description outside of the template. By some reason it didn't work for me but maybe I was doing something wrong with the template.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree it doesn't look super elegant.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sepans thanks for trying to figure this out together.

Do you have a good example (medium user) to test this with?
Also, I think I understand, but why do we need the n(..., where does the n come from?

@christianvuerings
Copy link
Owner

other pieces lgtm - just one question on the PR

@sepans
Copy link
Author

sepans commented Jan 12, 2016

Fixed that. Sorry I was feeling so guilty about not using jQuery templates, I thought thats what you meant. That n($) was supposed to be function($) which I accidentally deleted before committing the code. Thanks for catching that.

@medium (https://medium.com/@medium) could be used as an example user.

Do you want the built files to be committed with the PR?

Thanks

@christianvuerings
Copy link
Owner

@sepans looking way better thanks. And definitely leave the build files out for now, we always create those as part of the release process, thanks for asking though.

As for the jQuery template, I hope to find some time in the next couple of days to have a look at different options. I hope it's ok to keep this PR open for a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants