Merge pull request #5528 from cloudflare/dlapid/typos

Fix a few typos.

Author: danlapid

src/workerd/api/tail-worker-test.js

@@ -35,8 +35,8 @@ const unitTests :Workerd.Config = (
     (name = "hiber", worker = .hiberWorker),
     (name = "js-rpc-test", worker = .jsRpcWorker),
     (name = "TEST_TMPDIR", disk = (writable = true)),
-    # Dummy legacy tail worker (gets traces from alarms worker and produces trace for main tracer)
-    (name = "legacy", worker = .logLegacy, ),
+    # Dummy buffered tail worker (gets traces from alarms worker and produces trace for main tracer)
+    (name = "buffered", worker = .logBuffered, ),
     # Receives trace events from STW, used to check that STW produces trace events properly
     (name = "receiver", worker = .logReceiver, ),
     # Unified tail worker with tests
@@ -72,8 +72,8 @@ const alarmsWorker :Workerd.Worker = (
   bindings = [
     (name = "ns", durableObjectNamespace = "DurableObjectExample"),
   ],
-  # tailed by the main tail worker and the dummy legacy tail worker, to get traces for it too.
-  tails = ["legacy"],
+  # tailed by the main tail worker and the dummy buffered tail worker, to get traces for it too.
+  tails = ["buffered"],
   streamingTails = ["log"],
 );
 
@@ -133,7 +133,7 @@ const logReceiver :Workerd.Worker = (
   compatibilityFlags = ["experimental", "nodejs_compat"],
 );
 
-const logLegacy :Workerd.Worker = (
+const logBuffered :Workerd.Worker = (
   modules = [
     (name = "worker", esModule = embed "tail-worker-test-dummy.js")
   ],

src/workerd/api/tail-worker-test.wd-test

@@ -302,7 +302,7 @@ kj::String KJ_STRINGIFY(const TraceId& id);
 kj::String KJ_STRINGIFY(const InvocationSpanContext& context);
 kj::String KJ_STRINGIFY(const SpanContext& context);
 
-// The various structs defined below are used in both legacy tail workers
+// The various structs defined below are used in both buffered tail workers
 // and streaming tail workers to report tail events.
 
 // Describes a fetch request
@@ -422,7 +422,7 @@ struct EmailEventInfo final {
   EmailEventInfo clone() const;
 };
 
-// Describes a legacy tail worker request
+// Describes a buffered tail worker request
 struct TraceEventInfo final {
   struct TraceItem;
 

src/workerd/io/trace.h

@@ -169,7 +169,7 @@ void WorkerTracer::addLog(const tracing::InvocationSpanContext& context,
 
   // TODO(streaming-tail): Here we add the log to the trace object and the tail stream writer, if
   // available. If the given worker stage is only tailed by a streaming tail worker, adding the log
-  // to the legacy trace object is not needed; this will be addressed in a future refactor.
+  // to the buffered trace object is not needed; this will be addressed in a future refactor.
   KJ_IF_SOME(writer, maybeTailStreamWriter) {
     // If message is too big on its own, truncate it.
     writer->report(context,
@@ -200,7 +200,7 @@ void WorkerTracer::addSpan(tracing::CompleteSpan&& span) {
     return;
   }
 
-  // Note: spans are not available in the legacy tail worker, so we don't need an exceededSpanLimit
+  // Note: spans are not available in the buffered tail worker, so we don't need an exceededSpanLimit
   // variable for it and it can't cause truncation.
   auto& tailStreamWriter = KJ_UNWRAP_OR_RETURN(maybeTailStreamWriter);
 
@@ -526,7 +526,7 @@ void WorkerTracer::setReturn(
         timestamp.orDefault([&]() { return getTime(); }));
   }
 
-  // Add fetch response info for legacy tail worker
+  // Add fetch response info for buffered tail worker
   KJ_IF_SOME(info, fetchResponseInfo) {
     KJ_REQUIRE(KJ_REQUIRE_NONNULL(trace->eventInfo).is<tracing::FetchEventInfo>());
     KJ_ASSERT(trace->fetchResponseInfo == kj::none, "setFetchResponseInfo can only be called once");

src/workerd/io/tracer.c++

@@ -122,7 +122,7 @@ class BaseTracer: public kj::Refcounted {
 
   // Sets the return event for Streaming Tail Worker, including fetchResponseInfo (HTTP status code)
   // if available. Must not be called more than once, and fetchResponseInfo should only be set for
-  // fetch events. For legacy tail worker, there is no distinct return event so we only add
+  // fetch events. For buffered tail worker, there is no distinct return event so we only add
   // fetchResponseInfo to the trace if present.
   virtual void setReturn(kj::Maybe<kj::Date> time = kj::none,
       kj::Maybe<tracing::FetchResponseInfo> fetchResponseInfo = kj::none) = 0;

src/workerd/io/tracer.h

@@ -2165,7 +2165,7 @@ class Server::WorkerService final: public Service,
     kj::Maybe<kj::Own<WorkerTracer>> workerTracer = kj::none;
 
     if (legacyTailWorkers.size() > 0 || streamingTailWorkers.size() > 0) {
-      // Setting up legacy tail workers support, but only if we actually have tail workers
+      // Setting up buffered tail workers support, but only if we actually have tail workers
       // configured.
       auto tracer = kj::rc<PipelineTracer>();
       auto executionModel =
@@ -2182,7 +2182,7 @@ class Server::WorkerService final: public Service,
           kj::mv(tailStreamWriter));
 
       // When the tracer is complete, deliver the traces to both the parent
-      // and the legacy tail workers. We do NOT want to attach the tracer to the
+      // and the buffered tail workers. We do NOT want to attach the tracer to the
       // tracer->onComplete() promise here because it is the destructor of
       // the PipelineTracer that resolves the onComplete promise. If we attach
       // the tracer to the promise the tracer won't be destroyed while the