Mob commit. Changed provisioner tests to use shared_examples pattern

Used to test different OS Version and IaaS combinations.

Co-authored-by: Daniel Basner <[email protected]>
Co-authored-by: George Gelashvili <[email protected]>

Author: George Gelashvili

spec/packer/config/provisioners_spec.rb

@@ -1,6 +1,6 @@
 require 'rspec/expectations'
 
-RSpec::Matchers.define :include_provisioner do |expected_provisioner, after:[]|
+RSpec::Matchers.define :include_provisioner do |expected_provisioner, after: []|
 
   def provisioner_is_after?(actual_provisioners, after, provisioner_index)
     after_index = actual_provisioners.find_index do |provisioner|
@@ -58,72 +58,56 @@ def self.new_powershell_provisioner(command)
 
   def inspect
     case @provisioner_type
-      when :powershell
-        return "Powershell provisioner with command: '#{@command}'"
-      when :file
-        return "File Provisioner with source: '#{@source}' and destination: '#{@destination}'"
+    when :powershell
+      return "Powershell provisioner with command: '#{@command}'"
+    when :file
+      return "File Provisioner with source: '#{@source}' and destination: '#{@destination}'"
     end
   end
 
   def matches?(actual_provisioner)
     case @provisioner_type
-      when :powershell
-        actual_provisioner['type'] == 'powershell' &&
-        actual_provisioner.has_key?('inline') &&
-        actual_provisioner['inline'].find do |script_line|
-          if @command.is_a?(String)
-            script_line.eql? @command
-          elsif @command.is_a?(Regexp)
-            script_line =~ @command
-          else
-            raise "provisioner command neither string nor regex"
+    when :powershell
+      actual_provisioner['type'] == 'powershell' &&
+          actual_provisioner.has_key?('inline') &&
+          actual_provisioner['inline'].find do |script_line|
+            if @command.is_a?(String)
+              script_line.eql? @command
+            elsif @command.is_a?(Regexp)
+              script_line =~ @command
+            else
+              raise "provisioner command neither string nor regex"
+            end
           end
-        end
-      when :file
-        actual_provisioner['type'] == 'file' &&
-        actual_provisioner['source'] == @source &&
-        actual_provisioner['destination'] == @destination
-      else
-        false
+    when :file
+      actual_provisioner['type'] == 'file' &&
+          actual_provisioner['source'] == @source &&
+          actual_provisioner['destination'] == @destination
+    else
+      false
     end
   end
 end
 
-describe 'provisioners' do
-  before(:context) do
-    stemcell_deps_dir = Dir.mktmpdir('gcp')
-    ENV['STEMCELL_DEPS_DIR'] = stemcell_deps_dir
-    @provisioners = Packer::Config::Aws.new(
-        aws_access_key: '',
-        aws_secret_key: '',
-        region: '',
-        output_directory: 'some-output-directory',
-        os: 'windows2012R2',
-        version: '1200.1.2',
-        vm_prefix: '',
-        mount_ephemeral_disk: false
-    ).provisioners
-
-    FileUtils.rm_rf(stemcell_deps_dir)
-    ENV.delete('STEMCELL_DEPS_DIR')
-  end
+shared_examples "a standard provisioner" do |provisioner_config|
+  let(:provisioners) { provisioner_config.provisioners }
 
   it 'does not have nonsense provisioner' do
     nonsense_provisioner = TestProvisioner.new_powershell_provisioner('some-garbage')
-    expect(@provisioners).not_to include_provisioner(nonsense_provisioner), 'test matcher'
+    expect(provisioners).not_to include_provisioner(nonsense_provisioner), 'test matcher'
   end
 
   it 'uploads bosh ps-modules' do
     upload_bosh_ps_modules = TestProvisioner.new_file_provisioner('build/bosh-psmodules.zip', 'C:\provision\bosh-psmodules.zip')
-    expect(@provisioners).to include_provisioner(upload_bosh_ps_modules)
+    expect(provisioners).to include_provisioner(upload_bosh_ps_modules)
   end
 
   it 'uploads the install-bosh-psmodules script' do
     upload_install_bosh_ps_modules = TestProvisioner.new_file_provisioner(
         'scripts/install-bosh-psmodules.ps1',
         'C:\provision\install-bosh-psmodules.ps1'
     )
-    expect(@provisioners).to include_provisioner(upload_install_bosh_ps_modules)
+    expect(provisioners).to include_provisioner(upload_install_bosh_ps_modules)
   end
 
   it 'runs install bosh ps modules after uploading zip file and install script' do
@@ -134,26 +118,26 @@ def matches?(actual_provisioner)
         'C:\provision\install-bosh-psmodules.ps1'
     )
 
-    expect(@provisioners).to include_provisioner(install_modules_provisioner, after:[upload_install_modules, upload_modules])
+    expect(provisioners).to include_provisioner(install_modules_provisioner, after: [upload_install_modules, upload_modules])
   end
 
   it 'runs get-hotfix after windows updates are applied' do
     get_hotfix_prov = TestProvisioner.new_powershell_provisioner('Get-HotFix > hotfixes.log')
     wait_windows_update_prov = TestProvisioner.new_powershell_provisioner(/Wait-WindowsUpdates -Password .+ -User Provisioner/)
-    expect(@provisioners).to include_provisioner(get_hotfix_prov, after:[wait_windows_update_prov])
-    # expect(@provisioners).to include_provisioner(get_hotfix_prov)
+    expect(provisioners).to include_provisioner(get_hotfix_prov, after: [wait_windows_update_prov])
+    # expect(provisioners).to include_provisioner(get_hotfix_prov)
 
-    prov_index = @provisioners.find_index do |p|
+    prov_index = provisioners.find_index do |p|
       p['type'] == 'powershell' && p.has_key?('inline') && p['inline'].include?('Get-HotFix > hotfixes.log')
     end
     expect(prov_index).not_to be_nil, 'Could not find Get-Hotfix provisioner'
 
 
-    hotfixes_applied_index = @provisioners.find_index do |p|
+    hotfixes_applied_index = provisioners.find_index do |p|
       p['type'] == 'powershell' && p.has_key?('inline') && p['inline'].include?('Register-WindowsUpdatesTask')
     end
 
-    unregister_windows_index = @provisioners.find_index do |p|
+    unregister_windows_index = provisioners.find_index do |p|
       p['type'] == 'powershell' && p.has_key?('inline') && p['inline'].include?('Unregister-WindowsUpdatesTask')
     end
 
@@ -163,16 +147,16 @@ def matches?(actual_provisioner)
 
   it 'runs Unregister windows update after the post-RegisterWindowsUpdates windows-restart' do
     register_windows_updates_task_provisioner = TestProvisioner.new_powershell_provisioner('Register-WindowsUpdatesTask')
-    expect(@provisioners).to include_provisioner(register_windows_updates_task_provisioner), 'test matcher'
+    expect(provisioners).to include_provisioner(register_windows_updates_task_provisioner), 'test matcher'
 
 
     # noinspection RubyInterpreter
-    register_updates_index = @provisioners.find_index do |p|
+    register_updates_index = provisioners.find_index do |p|
       p['type'] == 'powershell' && p.has_key?('inline') && p['inline'].include?('Register-WindowsUpdatesTask')
     end
     expect(register_updates_index).not_to be_nil, 'Could not find RegisterWindowsUpdates provisioner'
 
-    post_register_provisioners = @provisioners[(register_updates_index + 1)..-1]
+    post_register_provisioners = provisioners[(register_updates_index + 1)..-1]
 
     prov_index = post_register_provisioners.find_index do |p|
       provisionerCommand = 'Unregister-WindowsUpdatesTask'
@@ -187,4 +171,63 @@ def matches?(actual_provisioner)
 
     expect(prov_index).to be > windows_restart_index, 'UnregisterWindowsUpdates not before windows-restart'
   end
+end
+
+describe 'provisioners' do
+  before(:context) do
+    @stemcell_deps_dir = Dir.mktmpdir('gcp')
+    ENV['STEMCELL_DEPS_DIR'] = @stemcell_deps_dir
+  end
+
+  after(:context) do
+    FileUtils.rm_rf(@stemcell_deps_dir)
+    ENV.delete('STEMCELL_DEPS_DIR')
+  end
+
+  context 'aws' do
+    standard_options = {
+      aws_access_key: '',
+      aws_secret_key: '',
+      region: '',
+      output_directory: 'some-output-directory',
+      version: '',
+    }
+
+    context '2012R2' do
+      it_behaves_like "a standard provisioner", Packer::Config::Aws.new(
+        standard_options.merge(os: 'windows2012R2')
+      )
+    end
+
+    context '1803' do
+      it_behaves_like "a standard provisioner", Packer::Config::Aws.new(
+          standard_options.merge(os: 'windows1803')
+      )
+    end
+  end
+
+  context 'vsphere' do
+    standard_options = {
+      output_directory: 'output_directory',
+      num_vcpus: 1,
+      mem_size: 1000,
+      product_key: 'key',
+      organization: 'me',
+      owner: 'me',
+      administrator_password: 'password',
+      source_path: 'source_path',
+      version: '',
+      enable_rdp: false,
+      new_password: 'new-password',
+      http_proxy: nil,
+      https_proxy: nil,
+      bypass_list: nil,
+    }
+
+    context '2012R2' do
+      it_behaves_like 'a standard provisioner', Packer::Config::VSphere.new(
+        standard_options.merge(os: 'windows2012R2')
+      )
+    end
+  end
 end