Merge pull request #110 from cloudscale-ch/test/kenneth/ansible-2.19

Add ansible-core 2.19+ compatibility

Author: k-304

.github/workflows/ansible-collection-integration-tests.yml

@@ -21,16 +21,19 @@ jobs:
       fail-fast: false
       matrix:
         ansible:
-          - 2.13
-          - 2.14
-          - 2.15
+          - 2.13.0
+          - 2.14.0
+          - 2.15.0
+          - 2.19.0b1
         include:
-          - ansible: 2.13
+          - ansible: 2.13.0
             python: 3.8
-          - ansible: 2.14
+          - ansible: 2.14.0
             python: 3.9
-          - ansible: 2.15
+          - ansible: 2.15.0
             python: 3.9
+          - ansible: 2.19.0b1
+            python: 3.12
     steps:
       - name: Check out code
         uses: actions/checkout@v4
@@ -46,7 +49,7 @@ jobs:
         run: |
           python -m pip install --upgrade pip
           # Install the latest ansible-core patchlevel version
-          pip install 'ansible-core~=${{ matrix.ansible }}.0'
+          pip install 'ansible-core~=${{ matrix.ansible }}'
           pip install -r tests/requirements.txt
 
       - name: Build and install collection

tests/integration/targets/custom_image/tasks/tests.yml

@@ -57,7 +57,7 @@
   assert:
     that:
       - image1.import_status == 'success'
-      - image1.name == "{{ cloudscale_resource_prefix }}-test-image"
+      - image1.name == cloudscale_resource_prefix + '-test-image'
 
 - name: Import a custom image (idempotency)
   cloudscale_ch.cloud.custom_image:
@@ -75,7 +75,7 @@
   assert:
     that:
       - image is not changed
-      - image.name == "{{ cloudscale_resource_prefix }}-test-image"
+      - image.name == cloudscale_resource_prefix + '-test-image'
       - image.uuid == image1.uuid
 
 - name: Import a custom image with bad url
@@ -163,7 +163,7 @@
   assert:
     that:
       - image2 is changed
-      - image2.name == "{{ cloudscale_resource_prefix }}-test-image2"
+      - image2.name == cloudscale_resource_prefix + '-test-image2'
       - image2.uuid != image1.uuid
 
 - name: Wait for import
@@ -178,7 +178,7 @@
   assert:
     that:
       - import_status is not changed
-      - import_status.name == "{{ cloudscale_resource_prefix }}-test-image2"
+      - import_status.name == cloudscale_resource_prefix + '-test-image2'
 
 - name: Get image by name
   cloudscale_ch.cloud.custom_image:
@@ -198,7 +198,7 @@
 - name: Verify Change the name of an image
   assert:
     that:
-      - change_name.name == "{{ cloudscale_resource_prefix }}-test-image-with-a-new-name"
+      - change_name.name == cloudscale_resource_prefix + '-test-image-with-a-new-name'
       - change_name is changed
 
 - name: Update slug of a custom image
@@ -219,7 +219,7 @@
 - name: Verify update slug of a custom image
   assert:
     that:
-      - image.slug == "ansible-image-slug"
+      - image.slug == 'ansible-image-slug'
 
 - name: Update tags of a custom image
   cloudscale_ch.cloud.custom_image:
@@ -231,7 +231,7 @@
   assert:
     that:
       - image is changed
-      - image.tags == "project: luna"
+      - image.tags.project == 'luna'
 
 - name: Update user_data_handling of a custom image
   cloudscale_ch.cloud.custom_image:
@@ -251,7 +251,7 @@
 - name: Verify update user_data_handling of a custom image
   assert:
     that:
-      - image.user_data_handling == "extend-cloud-config"
+      - image.user_data_handling == 'extend-cloud-config'
 
 - name: Update slug, tags and user_data_handling of a custom image
   cloudscale_ch.cloud.custom_image:
@@ -265,9 +265,9 @@
   assert:
     that:
       - image is changed
-      - image.slug == "yet-another-slug"
-      - image.tags == "project: jupiter"
-      - image.user_data_handling == "pass-through"
+      - image.slug == 'yet-another-slug'
+      - image.tags.project == 'jupiter'
+      - image.user_data_handling == 'pass-through'
 
 - name: List all custom images, there should be two
   uri:
@@ -279,7 +279,7 @@
 - name: Verify that two custom images are created by this test run
   assert:
     that:
-      - image_list.json | selectattr("name","search", "{{ cloudscale_resource_prefix }}" ) | list | length == 2
+      - image_list.json | selectattr("name","search", cloudscale_resource_prefix) | list | length == 2
 
 - name: Delete image by uuid
   cloudscale_ch.cloud.custom_image:
@@ -312,7 +312,7 @@
 - name: Verify that the two custom images of this test run are deleted
   assert:
     that:
-      - image_list.json | selectattr("name","search", "{{ cloudscale_resource_prefix }}" ) | list | length == 0
+      - image_list.json | selectattr("name","search", cloudscale_resource_prefix) | list | length == 0
 
 - name: Import a custom image
   cloudscale_ch.cloud.custom_image:
@@ -395,7 +395,7 @@
   assert:
     that:
       - image1_uefi.import_status == 'success'
-      - image1_uefi.name == "{{ cloudscale_resource_prefix }}-test-image-uefi"
+      - image1_uefi.name == cloudscale_resource_prefix + '-test-image-uefi'
 
 - name: Fail changing the firmware type of an already imported image from uefi to bios
   cloudscale_ch.cloud.custom_image:

tests/integration/targets/load_balancer/tasks/tests.yml

@@ -36,7 +36,7 @@
     that:
       - load_balancer is changed
       - load_balancer.status == 'running'
-      - load_balancer.name == cloudscale_resource_prefix + "-test"
+      - load_balancer.name == cloudscale_resource_prefix + '-test'
       - load_balancer.flavor.slug == cloudscale_test_flavor_lb
       - load_balancer.vip_addresses[0].subnet.uuid == snet.uuid
       - load_balancer.zone.slug == cloudscale_test_zone
@@ -61,7 +61,7 @@
     that:
       - load_balancer is not changed
       - load_balancer.status == 'running'
-      - load_balancer.name == cloudscale_resource_prefix + "-test"
+      - load_balancer.name == cloudscale_resource_prefix + '-test'
       - load_balancer.flavor.slug == cloudscale_test_flavor_lb
       - load_balancer.vip_addresses[0].subnet.uuid == snet.uuid
       - load_balancer.zone.slug == cloudscale_test_zone
@@ -79,7 +79,7 @@
     that:
       - load_balancer_default_flavor is changed
       - load_balancer_default_flavor.status == 'running'
-      - load_balancer_default_flavor.name == cloudscale_resource_prefix + "-test2"
+      - load_balancer_default_flavor.name == cloudscale_resource_prefix + '-test2'
       - load_balancer_default_flavor.flavor.slug == cloudscale_test_flavor_lb
       - load_balancer_default_flavor.zone.slug == cloudscale_test_zone
 
@@ -92,7 +92,7 @@
   assert:
     that:
       - load_balancer is not changed
-      - load_balancer.name == cloudscale_resource_prefix + "-test"
+      - load_balancer.name == cloudscale_resource_prefix + '-test'
 
 # Update running LB
 - name: Test update name and tags of a running load balancer in check mode
@@ -110,7 +110,7 @@
     that:
       - load_balancer is changed
       - load_balancer.status == 'running'
-      - load_balancer.name == cloudscale_resource_prefix + "-test"
+      - load_balancer.name == cloudscale_resource_prefix + '-test'
 
 - name: Test update name and tags of a running load balancer
   cloudscale_ch.cloud.load_balancer:
@@ -126,7 +126,7 @@
     that:
       - load_balancer is changed
       - load_balancer.status == 'running'
-      - load_balancer.name == cloudscale_resource_prefix + "-test-renamed"
+      - load_balancer.name == cloudscale_resource_prefix + '-test-renamed'
       - load_balancer.flavor.slug == cloudscale_test_flavor_lb
       - load_balancer.tags.project == 'ansible-test'
       - load_balancer.tags.stage == 'staging'
@@ -146,7 +146,7 @@
     that:
       - load_balancer is not changed
       - load_balancer.status == 'running'
-      - load_balancer.name == cloudscale_resource_prefix + "-test-renamed"
+      - load_balancer.name == cloudscale_resource_prefix + '-test-renamed'
       - load_balancer.flavor.slug == cloudscale_test_flavor_lb
       - load_balancer.tags.project == 'ansible-test'
       - load_balancer.tags.stage == 'staging'

tests/integration/targets/load_balancer_listener/tasks/tests.yml

@@ -45,7 +45,7 @@
   assert:
     that:
       - load_balancer_listener is changed
-      - load_balancer_listener.name == cloudscale_resource_prefix + "-test"
+      - load_balancer_listener.name == cloudscale_resource_prefix + '-test'
       - load_balancer_listener.pool.uuid == load_balancer_pool.uuid
       - load_balancer_listener.protocol == cloudscale_test_listener_protocol
       - load_balancer_listener.protocol_port == cloudscale_test_protocol_port
@@ -79,7 +79,7 @@
   assert:
     that:
       - load_balancer_listener is not changed
-      - load_balancer_listener.name == cloudscale_resource_prefix + "-test"
+      - load_balancer_listener.name == cloudscale_resource_prefix + '-test'
       - load_balancer_listener.pool.uuid == load_balancer_pool.uuid
       - load_balancer_listener.protocol == cloudscale_test_listener_protocol
       - load_balancer_listener.protocol_port == cloudscale_test_protocol_port
@@ -101,7 +101,7 @@
   assert:
     that:
       - load_balancer_listener is not changed
-      - load_balancer_listener.name == '{{ cloudscale_resource_prefix }}-test'
+      - load_balancer_listener.name == cloudscale_resource_prefix + '-test'
 
 # Update an existing LB listener
 - name: Test update a load balancer listener in check mode
@@ -127,7 +127,7 @@
   assert:
     that:
       - load_balancer_listener is changed
-      - load_balancer_listener.name == cloudscale_resource_prefix + "-test"
+      - load_balancer_listener.name == cloudscale_resource_prefix + '-test'
       - load_balancer_listener.pool.uuid == load_balancer_pool.uuid
       - load_balancer_listener.protocol == cloudscale_test_listener_protocol
       - load_balancer_listener.protocol_port == cloudscale_test_protocol_port
@@ -162,7 +162,7 @@
   assert:
     that:
       - load_balancer_listener is changed
-      - load_balancer_listener.name == cloudscale_resource_prefix + "-test-renamed"
+      - load_balancer_listener.name == cloudscale_resource_prefix + '-test-renamed'
       - load_balancer_listener.pool.uuid == load_balancer_pool.uuid
       - load_balancer_listener.protocol == cloudscale_test_listener_protocol
       - load_balancer_listener.protocol_port == cloudscale_test_protocol_port
@@ -198,7 +198,7 @@
   assert:
     that:
       - load_balancer_listener is not changed
-      - load_balancer_listener.name == cloudscale_resource_prefix + "-test-renamed"
+      - load_balancer_listener.name == cloudscale_resource_prefix + '-test-renamed'
       - load_balancer_listener.pool.uuid == load_balancer_pool.uuid
       - load_balancer_listener.protocol == cloudscale_test_listener_protocol
       - load_balancer_listener.protocol_port == cloudscale_test_protocol_port
@@ -223,7 +223,7 @@
   assert:
     that:
       - load_balancer_listener is changed
-      - load_balancer_listener.name == cloudscale_resource_prefix + "-test-renamed"
+      - load_balancer_listener.name == cloudscale_resource_prefix + '-test-renamed'
 
 - name: Test load balancer listener deletion by name
   cloudscale_ch.cloud.load_balancer_listener:

tests/integration/targets/load_balancer_pool/tasks/tests.yml

@@ -33,7 +33,7 @@
   assert:
     that:
       - load_balancer_pool is changed
-      - load_balancer_pool.name == cloudscale_resource_prefix + "-test"
+      - load_balancer_pool.name == cloudscale_resource_prefix + '-test'
       - load_balancer_pool.load_balancer.uuid == load_balancer.uuid
       - load_balancer_pool.tags.project == 'ansible-test'
       - load_balancer_pool.tags.stage == 'production'
@@ -54,7 +54,7 @@
   assert:
     that:
       - load_balancer_pool is not changed
-      - load_balancer_pool.name == cloudscale_resource_prefix + "-test"
+      - load_balancer_pool.name == cloudscale_resource_prefix + '-test'
       - load_balancer_pool.load_balancer.uuid == load_balancer.uuid
       - load_balancer_pool.tags.project == 'ansible-test'
       - load_balancer_pool.tags.stage == 'production'
@@ -69,7 +69,7 @@
   assert:
     that:
       - load_balancer_pool is not changed
-      - load_balancer_pool.name == cloudscale_resource_prefix + "-test"
+      - load_balancer_pool.name == cloudscale_resource_prefix + '-test'
 
 # Update LB Pool
 - name: Test update name and tags of a running load balancer pool in check mode
@@ -86,7 +86,7 @@
   assert:
     that:
       - load_balancer_pool is changed
-      - load_balancer_pool.name == cloudscale_resource_prefix + "-test"
+      - load_balancer_pool.name == cloudscale_resource_prefix + '-test'
 
 - name: Test update name and tags of a running load balancer pool
   cloudscale_ch.cloud.load_balancer_pool:
@@ -101,7 +101,7 @@
   assert:
     that:
       - load_balancer_pool is changed
-      - load_balancer_pool.name == cloudscale_resource_prefix + "-test-renamed"
+      - load_balancer_pool.name == cloudscale_resource_prefix + '-test-renamed'
       - load_balancer_pool.tags.project == 'ansible-test'
       - load_balancer_pool.tags.stage == 'staging'
       - load_balancer_pool.tags.sla == '8-5'
@@ -119,7 +119,7 @@
   assert:
     that:
       - load_balancer_pool is not changed
-      - load_balancer_pool.name == cloudscale_resource_prefix + "-test-renamed"
+      - load_balancer_pool.name == cloudscale_resource_prefix + '-test-renamed'
       - load_balancer_pool.tags.project == 'ansible-test'
       - load_balancer_pool.tags.stage == 'staging'
       - load_balancer_pool.tags.sla == '8-5'