update mds trigger thresholds with era change CMSSW_15_0_16 #49423

AlexAlbert41 · 2025-11-19T21:14:37Z

PR description:

This is a backport of #49373 and a response to the concerns raised in the previous back port: #49217.

This PR updates 2025 HMT shower thresholds for pp collisions to be implemented for Era 2025F. The thresholds change should now be correctly mapped to the era change.

Details were presented by @kakwok at the TSG Meeting on August 20. [1].

[1] https://indico.cern.ch/event/1571789/#35-exo-report-on-l1t-muon-show

PR validation:

Tuning of trigger thresholds for redistribution of rates within CSC station-rings for optimized physics performance.

cmsbuild · 2025-11-19T21:15:03Z

A new Pull Request was created by @AlexAlbert41 for CMSSW_15_0_X.

It involves the following packages:

Configuration/Eras (operations)
L1Trigger/CSCTriggerPrimitives (l1)

@BenjaminRS, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @eyigitba, @fabiocos, @giovanni-mocellin, @makortel, @missirol, @mmusich, @ptcox, @valuev this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Backported from update mds trigger thresholds with era change tracked #49373

cmsbuild · 2025-11-19T21:15:04Z

cms-bot internal usage

BenjaminRS · 2025-11-21T20:05:38Z

please test

cmsbuild · 2025-11-21T20:12:50Z

-1

Failed Tests: Build
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1920d/49603/summary.html
COMMIT: ef35f1d
CMSSW: CMSSW_15_0_X_2025-11-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49423/49603/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation error when building:

                 from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/classlib/3.1.3-2827e9dbeb7dd2aced5a46b8a966dfab/include/classlib/iobase/Socket.h:4,
                 from src/DQMServices/Core/interface/DQMNet.h:4,
                 from src/DQMServices/Core/interface/MonitorElement.h:9,
                 from src/DQMServices/Core/interface/DQMStore.h:4,
                 from src/DQMServices/Core/src/DQMStore.cc:3:
/usr/include/sys/socket.h:33:10: fatal error: /usr/include/bits/socket.h: Input/output error
   33 | #include 
      |          ^~~~~~~~~~~~~~~
compilation terminated.
>> Compiling  src/DQMServices/Core/src/QReport.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -DCMSSW_GIT_HASH='CMSSW_15_0_X_2025-11-18-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_X_2025-11-18-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_0_X_2025-11-18-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/classlib/3.1.3-2827e9dbeb7dd2aced5a46b8a966dfab/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/boost/1.80.0-f86c86a2508d5852d508f015ea7702b4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/protobuf/3.21.9-3b4dc3892e5c8da1829fdf0bfe570820/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/lcg/root/6.32.13-807da11fdf7fb4ed6e3041a1948d5a8f/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/tbb/v2021.9.0-054885a1b1d4ef9ec998d1bcd72c9241/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/DQMServices/Core/src/DQMServicesCore/QReport.cc.d src/DQMServices/Core/src/QReport.cc -o tmp/el8_amd64_gcc12/src/DQMServices/Core/src/DQMServicesCore/QReport.cc.o

quinnanm · 2025-11-21T23:15:13Z

please test

cmsbuild · 2025-11-21T23:42:53Z

-1

Failed Tests: UnitTests RelVals AddOn
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1920d/49605/summary.html
COMMIT: ef35f1d
CMSSW: CMSSW_15_0_X_2025-11-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49423/49605/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 19 errors in the following unit tests:

---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS
---> test TestConfigDP_12 had ERRORS
---> test TestConfigDP_2 had ERRORS
and more ...

Failed RelVals

135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
2500.3012500.301_NANOmc150X/step2_NANOmc150X.log
1306.01306.0_SingleMuPt1_UP15/step2_SingleMuPt1_UP15.log

Expand to see more relval errors ...

Failed AddOn Tests

fastsim

UNKNOWN

fastsim1

UNKNOWN

fastsim2

UNKNOWN

Expand to see more addon errors ...

BenjaminRS · 2025-11-22T15:51:30Z

please test

cmsbuild · 2025-11-22T15:58:57Z

-1

Failed Tests: Build
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1920d/49611/summary.html
COMMIT: ef35f1d
CMSSW: CMSSW_15_0_X_2025-11-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49423/49611/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation error when building:

In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/boost/1.80.0-f86c86a2508d5852d508f015ea7702b4/include/boost/asio/append.hpp:18,
                 from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/boost/1.80.0-f86c86a2508d5852d508f015ea7702b4/include/boost/asio.hpp:20,
                 from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_0_X_2025-11-18-1100/src/EventFilter/Utilities/interface/EvFDaqDirector.h:30,
                 from src/DQMServices/FileIO/plugins/DQMFileSaverBase.h:8,
                 from src/DQMServices/FileIO/plugins/DQMFileSaverBase.cc:15:
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/boost/1.80.0-f86c86a2508d5852d508f015ea7702b4/include/boost/asio/detail/config.hpp:1609:11: fatal error: /usr/include/linux/version.h: Input/output error
 1609 | # include 
      |           ^~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/boost/1.80.0-f86c86a2508d5852d508f015ea7702b4/include/boost/asio/append.hpp:18,
                 from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc12/external/boost/1.80.0-f86c86a2508d5852d508f015ea7702b4/include/boost/asio.hpp:20,

BenjaminRS · 2025-11-22T16:40:43Z

backport of #49373

srimanob · 2025-11-25T16:06:23Z

@cmsbuild please test

ftenchini · 2025-11-25T16:06:28Z

please test

makortel · 2025-11-25T16:09:53Z

L1Trigger/CSCTriggerPrimitives/python/cscTriggerPrimitiveDigis_cfi.py

 from L1Trigger.CSCTriggerPrimitives.params.auxiliaryParams import auxPSets
 from L1Trigger.CSCTriggerPrimitives.params.gemcscParams import gemcscPSets
-from L1Trigger.CSCTriggerPrimitives.params.showerParams import showerPSet,showerPSet_2025
+from L1Trigger.CSCTriggerPrimitives.params.showerParams import showerPSet,showerPSet_2025_AtoE,showerPSet_FtoG


This import asks for showerPSet_FtoG, but the showerParams.py defines showerPSet_2025_FtoG (note _2025 in the latter that is not in the former).

Thanks for the spot Matti: @AlexAlbert41 can you fix the typo here please.

Thanks for spotting this - sorry about that. This should be fixed now.

cmsbuild · 2025-11-25T16:29:29Z

-1

Failed Tests: UnitTests RelVals AddOn
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1920d/49670/summary.html
COMMIT: ef35f1d
CMSSW: CMSSW_15_0_X_2025-11-23-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49423/49670/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 18 errors in the following unit tests:

---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS
---> test TestConfigDP_12 had ERRORS
---> test TestConfigDP_2 had ERRORS
and more ...

Failed RelVals

135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
2500.3012500.301_NANOmc150X/step2_NANOmc150X.log
1306.01306.0_SingleMuPt1_UP15/step2_SingleMuPt1_UP15.log

Expand to see more relval errors ...

Failed AddOn Tests

fastsim

UNKNOWN

fastsim1

UNKNOWN

fastsim2

UNKNOWN

Expand to see more addon errors ...

cmsbuild · 2025-11-25T19:02:15Z

Pull request #49423 was updated. @BenjaminRS, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @quinnanm can you please check and sign again.

BenjaminRS · 2025-11-25T19:47:20Z

Please test

cmsbuild · 2025-11-25T21:50:21Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1920d/49677/summary.html
COMMIT: ac42e1d
CMSSW: CMSSW_15_0_X_2025-11-23-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49423/49677/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4031982
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4031962
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

BenjaminRS · 2025-11-26T10:48:25Z

+l1

cmsbuild · 2025-11-26T10:48:50Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

ftenchini · 2025-11-26T11:52:10Z

+1

update mds trigger thresholds with era change CMSSW_15_0_16

ef35f1d

cmsbuild added this to the CMSSW_15_0_X milestone Nov 19, 2025

cmsbuild added l1-pending operations-pending pending-signatures tests-pending orp-pending labels Nov 19, 2025

AlexAlbert41 mentioned this pull request Nov 19, 2025

updated L1 thresholds for MDS Trigger for CSCs for Era 2025F [backport of 49216] #49217

Closed

cmsbuild added tests-started and removed tests-pending labels Nov 21, 2025

cmsbuild added tests-rejected and removed tests-started labels Nov 21, 2025

cmsbuild added tests-started and removed tests-rejected labels Nov 21, 2025

cmsbuild added tests-rejected and removed tests-started labels Nov 21, 2025

cmsbuild added tests-started and removed tests-rejected labels Nov 22, 2025

cmsbuild added tests-rejected and removed tests-started labels Nov 22, 2025

cmsbuild added the backport-ok label Nov 22, 2025

cmsbuild added tests-started and removed tests-rejected labels Nov 25, 2025

makortel reviewed Nov 25, 2025

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Nov 25, 2025

fix import typo

ac42e1d

cmsbuild added tests-pending and removed tests-rejected labels Nov 25, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 25, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Nov 25, 2025

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Nov 26, 2025

cmsbuild added orp-approved and removed orp-pending labels Nov 26, 2025

cmsbuild merged commit 97fe750 into cms-sw:CMSSW_15_0_X Nov 26, 2025
8 checks passed

update mds trigger thresholds with era change CMSSW_15_0_16 #49423

update mds trigger thresholds with era change CMSSW_15_0_16 #49423

Uh oh!

Conversation

AlexAlbert41 commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenjaminRS commented Nov 21, 2025

Uh oh!

cmsbuild commented Nov 21, 2025

Failed Build

Uh oh!

quinnanm commented Nov 21, 2025

Uh oh!

cmsbuild commented Nov 21, 2025

Failed Unit Tests

Failed RelVals

Failed AddOn Tests

Uh oh!

BenjaminRS commented Nov 22, 2025

Uh oh!

cmsbuild commented Nov 22, 2025

Failed Build

Uh oh!

BenjaminRS commented Nov 22, 2025

Uh oh!

srimanob commented Nov 25, 2025

Uh oh!

ftenchini commented Nov 25, 2025

Uh oh!

makortel Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

BenjaminRS Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

AlexAlbert41 Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Nov 25, 2025

Failed Unit Tests

Failed RelVals

Failed AddOn Tests

Uh oh!

cmsbuild commented Nov 25, 2025

Uh oh!

BenjaminRS commented Nov 25, 2025

Uh oh!

cmsbuild commented Nov 25, 2025

Comparison Summary

Uh oh!

BenjaminRS commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

ftenchini commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AlexAlbert41 commented Nov 19, 2025 •

edited

Loading

cmsbuild commented Nov 19, 2025 •

edited

Loading

cmsbuild commented Nov 19, 2025 •

edited

Loading