fix: optimize ci

Author: cnzakii

scripts/rat.sh

@@ -37,11 +37,10 @@ fi
 
 
 # Download Apache RAT jar
-RAT_URL="https://repo1.maven.org/maven2/org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar"
-JAR_PART="${RAT_JAR}.part"
-
 echo "Downloading Apache RAT ${RAT_VERSION}..."
 
+RAT_URL="https://repo1.maven.org/maven2/org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar"
+JAR_PART="${RAT_JAR}.part"
 
 if command -v curl &> /dev/null; then
   curl -L --silent "${RAT_URL}" -o "${JAR_PART}" && mv "${JAR_PART}" "${RAT_JAR}"
@@ -52,34 +51,29 @@ else
   exit 1
 fi
 
-
-# Check if the JAR file is valid
-unzip -tq "${RAT_JAR}" &> /dev/null
+unzip -tq "${RAT_JAR}" > /dev/null
 if [ $? -ne 0 ]; then
-  rm "${RAT_JAR}"
-  echo "Download ${RAT_JAR} failed or the file is not a valid JAR."
-  exit -1
+  echo "Downloaded Apache RAT jar is invalid"
+  exit 1
 fi
 
 echo "Downloaded Apache RAT ${RAT_VERSION} successfully."
 
+
 # Run Apache RAT
 echo "Running Apache license check, this may take a while..."
+${java_cmd} -jar ${RAT_JAR} -d ${ROOT_DIR} -E "${ROOT_DIR}/.license-ignore" > "${TEMP_DIR}/rat-report.txt"
 
-"${java_cmd}" -jar "${RAT_JAR}" -E "${ROOT_DIR}/.license-ignore" -d "${ROOT_DIR}"  > "${TEMP_DIR}/rat-report.txt"
 
+# Check the result
 if [ $? -ne 0 ]; then
    echo "RAT exited abnormally"
    exit 1
+elif grep -q "??" "${TEMP_DIR}/rat-report.txt"; then
+    echo >&2 "Could not find Apache license headers in the following files:"
+    grep "??" "${TEMP_DIR}/rat-report.txt" >&2
+    exit 1
+else
+    echo "Apache license check passed."
 fi
 
-ERRORS="$(grep "??" "${TEMP_DIR}/rat-report.txt")"
-
-
-if [ -n "$ERRORS" ]; then
-  echo "Could not find Apache license headers in the following files:"
-  echo "$ERRORS"
-  exit 1
-else
-  echo "Apache license check passed."
-fi