fix: optimize ci

Author: cnzakii

scripts/rat.sh

@@ -19,17 +19,16 @@
 ### Apache RAT license check script ###
 # This script downloads Apache RAT and runs it to check the license headers of the source files.
 
-set -e # Exit immediately if a command exits with a non-zero status.
+set -e
 
-# Some variables
 ROOT_DIR="$(cd "$(dirname "$0")/.." && pwd)"
-TEMP_DIR="${ROOT_DIR}/temp"
+TMP_DIR="/tmp"
+
 RAT_VERSION="0.16.1"
-RAT_JAR="${TEMP_DIR}/apache-rat-${RAT_VERSION}.jar"
+RAT_JAR="${TMP_DIR}/apache-rat-${RAT_VERSION}.jar"
 
 
 cd "${ROOT_DIR}"
-mkdir -p "${TEMP_DIR}"
 
 # Set Java command
 if [ -x "${JAVA_HOME}/bin/java" ]; then
@@ -39,48 +38,43 @@ else
 fi
 
 
-# Download Apache RAT jar file if not exists
-if [ ! -f "${RAT_JAR}" ]; then
-    RAT_URL="https://repo1.maven.org/maven2/org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar"
-    JAR_PART="${RAT_JAR}.part"
-
-    echo "Downloading Apache RAT ${RAT_VERSION}..."
+# Download Apache RAT jar
+echo "Downloading Apache RAT ${RAT_VERSION}..."
 
-    if command -v curl &> /dev/null; then
-        curl -L --silent "${RAT_URL}" -o "${JAR_PART}"
-    elif command -v wget &> /dev/null; then
-        wget --quiet "${RAT_URL}" -O "${JAR_PART}"
-    else
-        echo "Neither curl nor wget found."
-        exit 1
-    fi
+RAT_URL="https://repo1.maven.org/maven2/org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar"
+JAR_PART="${RAT_JAR}.part"
 
-    mv "${JAR_PART}" "${RAT_JAR}"
+if command -v curl &> /dev/null; then
+  curl -L --silent "${RAT_URL}" -o "${JAR_PART}" && mv "${JAR_PART}" "${RAT_JAR}"
+elif command -v wget &> /dev/null; then
+  wget --quiet "${RAT_URL}" -O "${JAR_PART}" && mv "${JAR_PART}" "${RAT_JAR}"
+else
+  echo "Neither curl nor wget found."
+  exit 1
+fi
 
+unzip -tq "${RAT_JAR}" > /dev/null
+if [ $? -ne 0 ]; then
+  echo "Downloaded Apache RAT jar is invalid"
+  exit 1
+fi
 
-    # TODO: Strange phenomenon:its integrity cannot be verified, but it still works normally. (Ignore the check for now)
-    # Check if the JAR file is valid
-#    if ! unzip -tq "${RAT_JAR}" &> /dev/null; then
-#        rm "${RAT_JAR}"
-#        echo "Download ${RAT_JAR} failed or the file is not a valid JAR."
-#        exit 1
-#    fi
+echo "Downloaded Apache RAT ${RAT_VERSION} successfully."
 
-    echo "Downloaded Apache RAT ${RAT_VERSION} successfully."
-fi
 
 # Run Apache RAT
 echo "Running Apache license check, this may take a while..."
+${java_cmd} -jar ${RAT_JAR} -d ${ROOT_DIR} -E "${ROOT_DIR}/.license-ignore" > "${TEMP_DIR}/rat-report.txt"
 
-"${java_cmd}" -jar "${RAT_JAR}" -E "${ROOT_DIR}/.license-ignore" -d "${ROOT_DIR}" > "${TEMP_DIR}/rat-report.txt"
 
-if grep -q "??" "${TEMP_DIR}/rat-report.txt"; then
+# Check the result
+if [ $? -ne 0 ]; then
+   echo "RAT exited abnormally"
+   exit 1
+elif grep -q "??" "${TEMP_DIR}/rat-report.txt"; then
     echo >&2 "Could not find Apache license headers in the following files:"
     grep "??" "${TEMP_DIR}/rat-report.txt" >&2
     exit 1
 else
     echo "Apache license check passed."
 fi
-
-# Clean up
-rm -rf "${TEMP_DIR}"