Skip to content

Commit 06fcc8f

Browse files
authored
[playground] Fix syntax error from crashing the Compiler playground (facebook#34623)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> Fixes a syntax error causing the Compiler playground to crash. Resolves facebook#34622. ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> Tested locally and added a test. <img width="1470" height="836" alt="Screenshot 2025-09-27 at 8 13 07 AM" src="https://github.com/user-attachments/assets/29473682-94c3-49dc-9ee9-c2004062aaea" />
1 parent 91e5c3d commit 06fcc8f

File tree

2 files changed

+31
-1
lines changed

2 files changed

+31
-1
lines changed

compiler/apps/playground/__tests__/e2e/page.spec.ts

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,36 @@ test('disableMemoizationForDebugging flag works as expected', async ({
314314
expect(output).toMatchSnapshot('disableMemoizationForDebugging-output.txt');
315315
});
316316

317+
test('error is displayed when source has syntax error', async ({page}) => {
318+
const syntaxErrorSource = `function TestComponent(props) {
319+
const oops = props.
320+
return (
321+
<>{oops}</>
322+
);
323+
}`;
324+
const store: Store = {
325+
source: syntaxErrorSource,
326+
config: defaultConfig,
327+
showInternals: false,
328+
};
329+
const hash = encodeStore(store);
330+
await page.goto(`/#${hash}`);
331+
await page.waitForFunction(isMonacoLoaded);
332+
await expandConfigs(page);
333+
await page.screenshot({
334+
fullPage: true,
335+
path: 'test-results/08-source-syntax-error.png',
336+
});
337+
338+
const text =
339+
(await page.locator('.monaco-editor-output').allInnerTexts()) ?? [];
340+
const output = text.join('');
341+
342+
expect(output.replace(/\s+/g, ' ')).toContain(
343+
'Expected identifier to be defined before being used',
344+
);
345+
});
346+
317347
TEST_CASE_INPUTS.forEach((t, idx) =>
318348
test(`playground compiles: ${t.name}`, async ({page}) => {
319349
const store: Store = {

compiler/apps/playground/lib/compilation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ export function compile(
297297
if (!error.hasErrors() && otherErrors.length !== 0) {
298298
otherErrors.forEach(e => error.details.push(e));
299299
}
300-
if (error.hasErrors()) {
300+
if (error.hasErrors() || !transformOutput) {
301301
return [{kind: 'err', results, error}, language, baseOpts];
302302
}
303303
return [

0 commit comments

Comments
 (0)