Skip to content

Commit b1b0955

Browse files
authored
[DevTools] Fix inspected element scroll in Suspense tab (facebook#34355)
1 parent 1549bda commit b1b0955

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTab.css

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,15 @@
1616

1717
.TreeWrapper {
1818
border-top: 1px solid var(--color-border);
19-
flex: 1 1 var(--horizontal-resize-tree-percentage);
19+
flex: 1 1 65%;
2020
display: flex;
2121
flex-direction: row;
2222
height: 100%;
23+
overflow: auto;
2324
}
2425

2526
.InspectedElementWrapper {
26-
flex: 1 1 35%;
27+
flex: 0 0 calc(100% - var(--horizontal-resize-tree-percentage));
2728
overflow-x: hidden;
2829
overflow-y: auto;
2930
}
@@ -59,12 +60,12 @@
5960

6061
.TreeWrapper {
6162
border-top: 1px solid var(--color-border);
62-
flex: 1 1 var(--vertical-resize-tree-percentage);
63+
flex: 1 1 50%;
6364
overflow: hidden;
6465
}
6566

6667
.InspectedElementWrapper {
67-
flex: 1 1 50%;
68+
flex: 0 0 calc(100% - var(--vertical-resize-tree-percentage));
6869
}
6970

7071
.TreeWrapper + .ResizeBarWrapper .ResizeBar {

packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTimeline.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@
99
display: flex;
1010
flex-direction: column;
1111
flex-grow: 1;
12+
/*
13+
* `overflow: auto` will add scrollbars but the input will not actually grow beyond visible content.
14+
* `overflow: hidden` will constrain the input to its visible content.
15+
*/
16+
overflow: hidden;
1217
}
1318

1419
.SuspenseTimelineRootSwitcher {

packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeList.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
import * as React from 'react';
1111

1212
export default function SuspenseTreeList(_: {}): React$Node {
13-
return <div>Activity slices</div>;
13+
return <div>Activity slices not implemented yet</div>;
1414
}

0 commit comments

Comments
 (0)