Skip to content

Commit bbe3f4d

Browse files
authored
[flags] disableLegacyMode in native-fb (facebook#35120)
this is failing test too because we need the legacy mode in the react package until we fix the tests
1 parent 1ea46df commit bbe3f4d

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

packages/react-native-renderer/src/__tests__/ReactFabricAndNative-test.internal.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ describe('created with ReactFabric called with ReactNative', () => {
4040
require('react-native/Libraries/ReactPrivate/ReactNativePrivateInterface').getNativeTagFromPublicInstance;
4141
});
4242

43-
// @gate !disableLegacyMode
4443
it('find Fabric instances with the RN renderer', () => {
4544
const View = createReactNativeComponentClass('RCTView', () => ({
4645
validAttributes: {title: true},
@@ -61,7 +60,6 @@ describe('created with ReactFabric called with ReactNative', () => {
6160
expect(getNativeTagFromPublicInstance(instance)).toBe(2);
6261
});
6362

64-
// @gate !disableLegacyMode
6563
it('find Fabric nodes with the RN renderer', () => {
6664
const View = createReactNativeComponentClass('RCTView', () => ({
6765
validAttributes: {title: true},
@@ -82,7 +80,6 @@ describe('created with ReactFabric called with ReactNative', () => {
8280
expect(handle).toBe(2);
8381
});
8482

85-
// @gate !disableLegacyMode
8683
it('dispatches commands on Fabric nodes with the RN renderer', () => {
8784
nativeFabricUIManager.dispatchCommand.mockClear();
8885
const View = createReactNativeComponentClass('RCTView', () => ({
@@ -104,7 +101,6 @@ describe('created with ReactFabric called with ReactNative', () => {
104101
expect(UIManager.dispatchViewManagerCommand).not.toBeCalled();
105102
});
106103

107-
// @gate !disableLegacyMode
108104
it('dispatches sendAccessibilityEvent on Fabric nodes with the RN renderer', () => {
109105
nativeFabricUIManager.sendAccessibilityEvent.mockClear();
110106
const View = createReactNativeComponentClass('RCTView', () => ({
@@ -147,7 +143,6 @@ describe('created with ReactNative called with ReactFabric', () => {
147143
.ReactNativeViewConfigRegistry.register;
148144
});
149145

150-
// @gate !disableLegacyMode
151146
it('find Paper instances with the Fabric renderer', () => {
152147
const View = createReactNativeComponentClass('RCTView', () => ({
153148
validAttributes: {title: true},
@@ -168,7 +163,6 @@ describe('created with ReactNative called with ReactFabric', () => {
168163
expect(instance._nativeTag).toBe(3);
169164
});
170165

171-
// @gate !disableLegacyMode
172166
it('find Paper nodes with the Fabric renderer', () => {
173167
const View = createReactNativeComponentClass('RCTView', () => ({
174168
validAttributes: {title: true},
@@ -189,7 +183,6 @@ describe('created with ReactNative called with ReactFabric', () => {
189183
expect(handle).toBe(3);
190184
});
191185

192-
// @gate !disableLegacyMode
193186
it('dispatches commands on Paper nodes with the Fabric renderer', () => {
194187
UIManager.dispatchViewManagerCommand.mockReset();
195188
const View = createReactNativeComponentClass('RCTView', () => ({
@@ -212,7 +205,6 @@ describe('created with ReactNative called with ReactFabric', () => {
212205
expect(nativeFabricUIManager.dispatchCommand).not.toBeCalled();
213206
});
214207

215-
// @gate !disableLegacyMode
216208
it('dispatches sendAccessibilityEvent on Paper nodes with the Fabric renderer', () => {
217209
ReactNativePrivateInterface.legacySendAccessibilityEvent.mockReset();
218210
const View = createReactNativeComponentClass('RCTView', () => ({

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const disableCommentsAsDOMContainers: boolean = true;
3636
export const disableInputAttributeSyncing: boolean = false;
3737
export const disableLegacyContext: boolean = false;
3838
export const disableLegacyContextForFunctionComponents: boolean = false;
39-
export const disableLegacyMode: boolean = true;
39+
export const disableLegacyMode: boolean = false;
4040
export const disableSchedulerTimeoutInWorkLoop: boolean = false;
4141
export const disableTextareaChildren: boolean = false;
4242
export const enableAsyncDebugInfo: boolean = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const disableCommentsAsDOMContainers: boolean = true;
2121
export const disableInputAttributeSyncing: boolean = false;
2222
export const disableLegacyContext: boolean = true;
2323
export const disableLegacyContextForFunctionComponents: boolean = true;
24-
export const disableLegacyMode: boolean = true;
24+
export const disableLegacyMode: boolean = false;
2525
export const disableSchedulerTimeoutInWorkLoop: boolean = false;
2626
export const disableTextareaChildren: boolean = false;
2727
export const enableAsyncDebugInfo: boolean = false;

0 commit comments

Comments
 (0)