Merge pull request #169 from codecrafters-io/andy/fix

andy1li · web-flow · commit 54bc945c9a0f · 2025-11-14T06:13:52.000+08:00
Remove single quotes in #gu3 Backslash within double quotes
diff --git a/internal/stage_q5.go b/internal/stage_q5.go
@@ -52,7 +52,7 @@ func testQ5(stageHarness *test_case_harness.TestCaseHarness) error {
 		fmt.Sprintf(`echo "%s'%s'\\'%s"`, L[0], L[1], L[2]),
 		fmt.Sprintf(`echo "%s\"insidequotes"%s\"`, L[0], L[1]),
 		fmt.Sprintf(`echo "mixed\"quote'%s'\\"`, L[4]),
-		fmt.Sprintf(`%s '%s' '%s' '%s'`, CUSTOM_CAT_COMMAND, filePaths[0], filePaths[1], filePaths[2]),
+		fmt.Sprintf(`%s %q %q %q`, CUSTOM_CAT_COMMAND, filePaths[0], filePaths[1], filePaths[2]),
 	}
 	expectedOutputs := []string{
 		fmt.Sprintf(`%s'%s'\'%s`, L[0], L[1], L[2]),
diff --git a/internal/test_helpers/fixtures/ash/quoting/pass b/internal/test_helpers/fixtures/ash/quoting/pass
@@ -99,7 +99,7 @@ Debug = true
 [33m[your-program] [0m$ echo "mixed\"quote'script'\\"
 [33m[your-program] [0mmixed"quote'script'\
 [33m[tester::#GU3] [0m[92m✓ Received expected response[0m
-[33m[your-program] [0m$ cat '/tmp/rat/"f 38"' '/tmp/rat/"f\93"' '/tmp/rat/f57'
+[33m[your-program] [0m$ cat "/tmp/rat/\"f 38\"" "/tmp/rat/\"f\\93\"" "/tmp/rat/f57"
 [33m[your-program] [0mbanana pineapple.raspberry blueberry.apple pineapple.
 [33m[tester::#GU3] [0m[92m✓ Received expected response[0m
 [33m[your-program] [0m$ 
diff --git a/internal/test_helpers/fixtures/bash/quoting/pass b/internal/test_helpers/fixtures/bash/quoting/pass
@@ -99,7 +99,7 @@ Debug = true
 [33m[your-program] [0m$ echo "mixed\"quote'script'\\"
 [33m[your-program] [0mmixed"quote'script'\
 [33m[tester::#GU3] [0m[92m✓ Received expected response[0m
-[33m[your-program] [0m$ cat '/tmp/rat/"f 38"' '/tmp/rat/"f\93"' '/tmp/rat/f57'
+[33m[your-program] [0m$ cat "/tmp/rat/\"f 38\"" "/tmp/rat/\"f\\93\"" "/tmp/rat/f57"
 [33m[your-program] [0mbanana pineapple.raspberry blueberry.apple pineapple.
 [33m[tester::#GU3] [0m[92m✓ Received expected response[0m
 [33m[your-program] [0m$ 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ func testQ5(stageHarness *test_case_harness.TestCaseHarness) error {`
`52`	`52`	fmt.Sprintf(`echo "%s'%s'\\'%s"`, L[0], L[1], L[2]),
`53`	`53`	fmt.Sprintf(`echo "%s\"insidequotes"%s\"`, L[0], L[1]),
`54`	`54`	fmt.Sprintf(`echo "mixed\"quote'%s'\\"`, L[4]),
`55`		- fmt.Sprintf(`%s '%s' '%s' '%s'`, CUSTOM_CAT_COMMAND, filePaths[0], filePaths[1], filePaths[2]),
	`55`	+ fmt.Sprintf(`%s %q %q %q`, CUSTOM_CAT_COMMAND, filePaths[0], filePaths[1], filePaths[2]),
`56`	`56`	`}`
`57`	`57`	`expectedOutputs := []string{`
`58`	`58`	fmt.Sprintf(`%s'%s'\'%s`, L[0], L[1], L[2]),
-Original file line number
+Diff line change
 [33m[your-program] [0m$ echo "mixed\"quote'script'\\"
 [33m[your-program] [0mmixed"quote'script'\
 [33m[tester::#GU3] [0m[92m✓ Received expected response[0m
 -[33m[your-program] [0m$ cat '/tmp/rat/"f 38"' '/tmp/rat/"f\93"' '/tmp/rat/f57'
 +[33m[your-program] [0m$ cat "/tmp/rat/\"f 38\"" "/tmp/rat/\"f\\93\"" "/tmp/rat/f57"
 [33m[your-program] [0mbanana pineapple.raspberry blueberry.apple pineapple.
 [33m[tester::#GU3] [0m[92m✓ Received expected response[0m
 [33m[your-program] [0m$