Asg management workaround improve pr devel 1.x (#763)

* Php unix socket pr 1.x (#724)

* Moving cachetool adapter setup to the installer role and adding a test.

* Updating cachetool documentation.

* Php unix socket pr 1.x (#726)

* Moving cachetool adapter setup to the installer role and adding a test.

* Updating cachetool documentation.

* Making sure _cachetool_adapter is always set.

* Optional-drush-cr-before-import (#728)

* 73171 fixing cachetool checks fpm pr 1.x (#729)

* skipping cachetool check when no fpm

* remove empty line

---------

Co-authored-by: filip <[email protected]>

* asg_management_fix_and_improve (#733)

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* Adding-delay-opcache-status-check (#737)

* Adding-delay-opcache-status-check

* Removing-failed-when

* fix_var_name_for_asg_management (#739)

* replace_ansible_pause_module (#747)

* fix_asg_management_workaround_for_squashfs (#754)

* fix_asg_management_workaround_for_squashfs

* fix_asg_management_workaround_for_squashfs

* fix_asg_management_workaround_task_condition (#756)

* aws_profile_for_asg_management (#758)

* aws_profile_for_asg_management

* aws_profile_for_asg_management_case_with_default_profile_absent

* ansible_module_requires_too_much_perms_just_for_autoscaling_management_so_replacing_with_aws_cli_from_role

* fix condition

* asg_management_workaround_improve_fix_conditions

---------

Co-authored-by: Greg Harvey <[email protected]>
Co-authored-by: drazenCE <[email protected]>
Co-authored-by: Filip Rupic <[email protected]>
Co-authored-by: filip <[email protected]>

Author: 5 people

roles/deploy_code/tasks/cleanup.yml

@@ -274,7 +274,7 @@
               when:
                 - asg_management.name is defined
                 - asg_management.name | length > 0
-                - asg_management.refresh_asg_instances is defined
+                - asg_management.refresh_asg_instances | default(true)
                 - asg_management.refresh_asg_instances
 
             - name: Start any services we stopped if the image re-mounting failed and ASG management is disabled.
@@ -288,7 +288,7 @@
               when:
                 - deploy_code.service_action == "stop"
                 - deploy_code.services | length > 0
-                - not asg_management.refresh_asg_instances or asg_management.name is not defined
+                - asg_management.refresh_asg_instances is not defined or not asg_management.refresh_asg_instances or asg_management.name is not defined
 # End of the squashFS block.
 
 - name: Trigger an infrastructure rebuild.